Code

[beta-1.85] backport #136577#136857

Code

Merged

bors merged 13 commits intorust-lang:betarust-lang/rust:betafrom

dianne:backport-pattern-diagnosticsdianne/rust:backport-pattern-diagnosticsCopy head branch name to clipboard

Feb 13, 2025

Commits

Commits on Feb 11, 2025

• pattern migration: move labels out of the suggestion struct

  Show description for acec586
  dianne

  committed
  acec586

  Copy full SHA for acec586

• reword pattern migration diagnostic to make sense in all editions

  Show description for 1a18daa
  dianne

  committed
  1a18daa

  Copy full SHA for 1a18daa

• use more specific wording for subpatterns from macro expansions

  Show description for a9465de
  dianne

  committed
  a9465de

  Copy full SHA for a9465de

• add tests for label formatting

  Show description for f8b23cd
  dianne

  committed
  f8b23cd

  Copy full SHA for f8b23cd

• highlight the whole problem subpattern when pointing out the default binding mode

  Show description for 2ee601c
  dianne

  committed
  2ee601c

  Copy full SHA for 2ee601c

• experimentally label the spans for default binding modes

  Show description for 6ff2d19
  dianne

  committed
  6ff2d19

  Copy full SHA for 6ff2d19

• don't include trailing open parens in labels for reference patterns

  Show description for 97cb2d5
  dianne

  committed
  97cb2d5

  Copy full SHA for 97cb2d5

• separate labels for default binding mode spans into their own notes

  Show description for 215bfdd
  dianne

  committed
  215bfdd

  Copy full SHA for 215bfdd

• reword default binding mode notes

  Show description for ee0838f
  dianne

  committed
  ee0838f

  Copy full SHA for ee0838f

• peace of mind: remove a call to `Option::expect`

  Show description for 2f29577
  dianne

  committed
  2f29577

  Copy full SHA for 2f29577

• try to suggest eliding redundant binding modifiers

  Show description for 909010e
  dianne

  committed
  909010e

  Copy full SHA for 909010e

• peace of mind: be absolutely sure we don't try to emit a 0-part suggestion

  Show description for c8e8068
  dianne

  committed
  c8e8068

  Copy full SHA for c8e8068

• add more pattern migration tests

  Show description for 8ee0fcb
  dianne

  committed
  8ee0fcb

  Copy full SHA for 8ee0fcb