Skip to content

Stabilise os_string_pathbuf_leak #137992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

Stabilise os_string_pathbuf_leak #137992

merged 1 commit into from
Jun 7, 2025

Conversation

its-the-shrimp
Copy link
Contributor

This PR stabilises #[feature(os_string_pathbuf_leak)], which defines 2 new methods in the std:

impl OsString {
    pub fn leak<'a>(self) -> &'a mut OsStr;
}

impl PathBuf {
    pub fn leak<'a>(self) -> &'a mut Path;
}

ACP: rust-lang/libs-team#389
Tracking issue: #125965
Implementation: #125966

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@its-the-shrimp its-the-shrimp force-pushed the stabilise_os_string_pathbuf_leak branch from 171e39d to e24d91d Compare March 4, 2025 11:45
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@its-the-shrimp its-the-shrimp force-pushed the stabilise_os_string_pathbuf_leak branch from 332f5a5 to 1a6315a Compare March 4, 2025 21:30
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@its-the-shrimp its-the-shrimp force-pushed the stabilise_os_string_pathbuf_leak branch from 1a6315a to 732b63c Compare March 4, 2025 21:43
@cuviper
Copy link
Member

cuviper commented Mar 4, 2025

This still needs FCP...

@rustbot label -T-libs +T-libs-api
r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2025
@rustbot rustbot assigned dtolnay and unassigned cuviper Mar 4, 2025
@dtolnay
Copy link
Member

dtolnay commented Mar 5, 2025

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Mar 5, 2025 •
edited by m-ou-se
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 5, 2025
@dtolnay dtolnay added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 25, 2025
@bors
Copy link
Collaborator

bors commented May 26, 2025

☔ The latest upstream changes (presumably #141567) made this pull request unmergeable. Please resolve the merge conflicts.

@joshtriplett joshtriplett removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 27, 2025
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label May 27, 2025
@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label May 27, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 27, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 6, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 6, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jun 6, 2025
@rustbot rustbot mentioned this pull request Jun 6, 2025
Open
dtolnay
dtolnay approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay dtolnay force-pushed the stabilise_os_string_pathbuf_leak branch from 732b63c to eba3a61 Compare June 6, 2025 19:07
@dtolnay
Copy link
Member

dtolnay commented Jun 6, 2025

@dtolnay
Copy link
Member

dtolnay commented Jun 6, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 6, 2025

📌 Commit eba3a61 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2025
@jhpratt
Rollup merge of rust-lang#137992 - its-the-shrimp:stabilise_os_string…
5fbd942 
…_pathbuf_leak, r=dtolnay

Stabilise `os_string_pathbuf_leak`

This PR stabilises `#[feature(os_string_pathbuf_leak)]`, which defines 2 new methods in the std:

```rs
impl OsString {
    pub fn leak<'a>(self) -> &'a mut OsStr;
}

impl PathBuf {
    pub fn leak<'a>(self) -> &'a mut Path;
}
```

ACP: rust-lang/libs-team#389
Tracking issue: rust-lang#125965
Implementation: rust-lang#125966
This was referenced Jun 7, 2025
Closed
Merged
bors added a commit that referenced this pull request Jun 7, 2025
@bors
Auto merge of #142142 - jhpratt:rollup-frlezq2, r=jhpratt
c57119b 
Rollup of 8 pull requests

Successful merges:

 - #137992 (Stabilise `os_string_pathbuf_leak`)
 - #141558 (Limit the size of cgu names when using the `-Zhuman-readable-cgu-name…)
 - #141797 (compiler: set Apple frame pointers by architecture)
 - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them)
 - #142045 (Make obligation cause code suggestions verbose)
 - #142076 (Check documentation of bootstrap in PR CI)
 - #142110 (Add solaris targets to build-manifest)
 - #142131 (Make cast suggestions verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 06a2daf into rust-lang:master Jun 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
rust-timer added a commit that referenced this pull request Jun 7, 2025
@rust-timer
Unrolled build for #137992
0ded11f 
Rollup merge of #137992 - its-the-shrimp:stabilise_os_string_pathbuf_leak, r=dtolnay

Stabilise `os_string_pathbuf_leak`

This PR stabilises `#[feature(os_string_pathbuf_leak)]`, which defines 2 new methods in the std:

```rs
impl OsString {
    pub fn leak<'a>(self) -> &'a mut OsStr;
}

impl PathBuf {
    pub fn leak<'a>(self) -> &'a mut Path;
}
```

ACP: rust-lang/libs-team#389
Tracking issue: #125965
Implementation: #125966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
8 participants
@its-the-shrimp @rustbot @rust-log-analyzer @cuviper @dtolnay @rfcbot @bors @joshtriplett