Report line number of test when should_panic test failed #138603
Conversation
|
Failed to set assignee to
|
rustbot
added
A-compiletest
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
This comment was marked as outdated.
This comment was marked as outdated.
|
Could not assign reviewer from: |
This comment has been minimized.
This comment has been minimized.
|
This looks like a libtest change, so r? libs (or testing-devex?) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Test names are nits, but make the reason for each test self describing.
I think it probably makes sense to also fix the substring tests if they're also broken (I haven't manually checked those messages to see if there's span info coming from elsewhere in the stack, but these seem like they should be tested with the same tests as are introduced here).
xizheyin
force-pushed
the
issue-137405
branch
2 times, most recently
from
21b9d4f to
c7b4523
Compare
This comment has been minimized.
This comment has been minimized.
Though reviews are still very much appreciated 😁 |
|
@bors try Before the change fails snapshots in Cargo's test testsuite |
Report line number of test when should_panic test failed Closes rust-lang#137405 --- try-job: x86_64-gnu-llvm-19-3 try-job: test-various
|
⌛ Trying commit 92c0fc4 with merge e3d12c70105892942a1e11612422c4dd5870277f... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
Oops, still failed. maybe |
Now maybe it's okay. I learned a lot and next time I can look for the appropriate directives in similar tests. |
|
@bors try |
|
⌛ Trying commit 5a13225 with merge 183e9d447d46102eff75d541478457051524346d... |
Report line number of test when should_panic test failed Closes rust-lang#137405 --- try-job: x86_64-gnu-llvm-19-3 try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
Signed-off-by: xizheyin <[email protected]>
|
I looked at other tests in the same level directory and they usually had |
|
@bors try |
Report line number of test when should_panic test failed Closes rust-lang#137405 --- try-job: x86_64-gnu-llvm-19-3 try-job: test-various
compiletest: Trim whitespace from environment variable names When a test contains a directive like `//@ exec-env: FOO=bar`, compiletest currently includes that leading space in the name of the environment variable, so it is defined as ` FOO` instead of `FOO`. This is an annoying footgun that is pretty much never intended, especially since most other directives *do* trim whitespace. So let's get rid of it by trimming the environment variable name. Values remain untrimmed, since there could conceivably be a use-case for values with leading space, but perhaps we'll end up trimming values too in the future. Recently observed in rust-lang#138603 (comment). Fixes rust-lang#132990. Supersedes rust-lang#133148. r? jieyouxu
tests/ui/test-attrs/test-should-panic-failed-show-span.run.stdout
Outdated
Show resolved
Hide resolved
Signed-off-by: xizheyin <[email protected]>
compiletest: Trim whitespace from environment variable names When a test contains a directive like `//@ exec-env: FOO=bar`, compiletest currently includes that leading space in the name of the environment variable, so it is defined as ` FOO` instead of `FOO`. This is an annoying footgun that is pretty much never intended, especially since most other directives *do* trim whitespace. So let's get rid of it by trimming the environment variable name. Values remain untrimmed, since there could conceivably be a use-case for values with leading space, but perhaps we'll end up trimming values too in the future. Recently observed in rust-lang#138603 (comment). Fixes rust-lang#132990. Supersedes rust-lang#133148. --- try-job: test-various
Closes #137405
try-job: x86_64-gnu-llvm-19-3
try-job: test-various