Implement overflow for infinite implied lifetime bounds #138676

compiler-errors · 2025-03-18T17:45:47Z

Not a great error message, but better than a hang

Fixes #138665
Fixes #102966
Fixes #115407

r? lcnr

compiler-errors · 2025-03-18T17:52:22Z

…nds, r=<try> Implement overflow for infinite implied lifetime bounds Not a great error message, but better than a hang r? lcnr

bors · 2025-03-18T17:53:33Z

⌛ Trying commit 7ed922a with merge b32fc44...

fmease · 2025-03-18T18:22:10Z

I assume this also fixes #102966 and #115407? (Also CC closed PR #103309 which had a different and unsound approach)

bors · 2025-03-18T20:01:03Z

☀️ Try build successful - checks-actions
Build commit: b32fc44 (b32fc44666c052e7cf07ab471bfb6f9ec571902f)

compiler-errors · 2025-03-18T21:13:34Z

@rust-timer build b32fc44
@craterbot check

craterbot · 2025-03-18T21:14:05Z

👌 Experiment pr-138676 created and queued.
🤖 Automatically detected try build b32fc44
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-03-18T21:14:26Z

🚧 Experiment pr-138676 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rust-timer · 2025-03-18T23:55:57Z

Finished benchmarking commit (b32fc44): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Cycles

Results (secondary 8.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.3%	[8.3%, 8.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.359s -> 777.553s (0.15%)
Artifact size: 365.12 MiB -> 365.13 MiB (0.00%)

lcnr · 2025-03-19T14:09:36Z

compiler/rustc_hir_analysis/src/outlives/implicit_infer.rs

-    loop {
-        let mut predicates_added = false;
+    for i in 0.. {
+        let mut predicates_added: Option<Vec<_>> = None;


just use a Vec with .is_empty()?

still relevant

lcnr · 2025-03-19T14:13:16Z

tests/ui/implied-bounds/overflow.rs

@@ -0,0 +1,11 @@
+trait Tailed<'a>: 'a {


pls add doc comment/link to issue

compiler/rustc_hir_analysis/src/outlives/implicit_infer.rs

lcnr

:3 nits, but otherwise r=me

craterbot · 2025-03-19T18:42:51Z

🎉 Experiment pr-138676 is completed!
📊 2 regressed and 1 fixed (599834 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

compiler-errors · 2025-04-07T21:45:15Z

@bors r=lcnr rollup

bors · 2025-04-07T21:45:18Z

📌 Commit 268c56e has been approved by lcnr

It is now in the queue for this repository.

…ounds, r=lcnr Implement overflow for infinite implied lifetime bounds Not a great error message, but better than a hang Fixes rust-lang#138665 Fixes rust-lang#102966 Fixes rust-lang#115407 r? lcnr

…errors Rollup of 19 pull requests Successful merges: - rust-lang#138676 (Implement overflow for infinite implied lifetime bounds) - rust-lang#139024 (Make error message for missing fields with `..` and without `..` more consistent) - rust-lang#139098 (Tell LLVM about impossible niche tags) - rust-lang#139124 (compiler: report error when trait object type param reference self) - rust-lang#139321 (Update to new rinja version (askama)) - rust-lang#139346 (Don't construct preds w escaping bound vars in `diagnostic_hir_wf_check`) - rust-lang#139386 (make it possible to use stage0 libtest on compiletest) - rust-lang#139421 (Fix trait upcasting to dyn type with no principal when there are projections) - rust-lang#139468 (Don't call `Span::with_parent` on the good path in `has_stashed_diagnostic`) - rust-lang#139476 (rm `RegionInferenceContext::var_infos`) - rust-lang#139481 (Add job summary links to post-merge report) - rust-lang#139485 (compiletest: Stricter parsing for diagnostic kinds) - rust-lang#139490 (Update some comment/docs related to "extern intrinsic" removal) - rust-lang#139491 (Update books) - rust-lang#139496 (Revert r-a changes of rust-lang#139455) - rust-lang#139500 (document panic behavior of Vec::resize and Vec::resize_with) - rust-lang#139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types) - rust-lang#139504 (add missing word in doc comment) - rust-lang#139507 (compiletest: Trim whitespace from environment variable names) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#138676 (Implement overflow for infinite implied lifetime bounds) - rust-lang#139024 (Make error message for missing fields with `..` and without `..` more consistent) - rust-lang#139098 (Tell LLVM about impossible niche tags) - rust-lang#139124 (compiler: report error when trait object type param reference self) - rust-lang#139321 (Update to new rinja version (askama)) - rust-lang#139346 (Don't construct preds w escaping bound vars in `diagnostic_hir_wf_check`) - rust-lang#139386 (make it possible to use stage0 libtest on compiletest) - rust-lang#139421 (Fix trait upcasting to dyn type with no principal when there are projections) - rust-lang#139464 (Allow for reparsing failure when reparsing a pasted metavar.) - rust-lang#139490 (Update some comment/docs related to "extern intrinsic" removal) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138676 - compiler-errors:overflow-implied-bounds, r=lcnr Implement overflow for infinite implied lifetime bounds Not a great error message, but better than a hang Fixes rust-lang#138665 Fixes rust-lang#102966 Fixes rust-lang#115407 r? lcnr

rustbot assigned lcnr Mar 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 18, 2025

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025

lcnr reviewed Mar 19, 2025

View reviewed changes

tests/ui/implied-bounds/overflow.rs

@@ -0,0 +1,11 @@

trait Tailed<'a>: 'a {

Copy link

Contributor

lcnr Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add doc comment/link to issue

lcnr reviewed Mar 19, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/outlives/implicit_infer.rs Outdated Show resolved Hide resolved

lcnr reviewed Mar 19, 2025

View reviewed changes

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 19, 2025

compiler-errors force-pushed the overflow-implied-bounds branch from 7ed922a to 2ecc7ba Compare April 7, 2025 20:35

Implement overflow for infinite implied lifetime bounds

268c56e

compiler-errors force-pushed the overflow-implied-bounds branch from 2ecc7ba to 268c56e Compare April 7, 2025 21:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2025

Zalathar mentioned this pull request Apr 8, 2025

Rollup of 19 pull requests #139508

Closed

Zalathar mentioned this pull request Apr 8, 2025

Rollup of 10 pull requests #139525

Merged

bors merged commit 2b1afcb into rust-lang:master Apr 8, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement overflow for infinite implied lifetime bounds #138676

Implement overflow for infinite implied lifetime bounds #138676

compiler-errors commented Mar 18, 2025 •

edited by fmease

Loading

compiler-errors commented Mar 18, 2025

bors commented Mar 18, 2025

fmease commented Mar 18, 2025 •

edited

Loading

bors commented Mar 18, 2025

compiler-errors commented Mar 18, 2025

This comment has been minimized.

craterbot commented Mar 18, 2025

craterbot commented Mar 18, 2025

rust-timer commented Mar 18, 2025

lcnr Mar 19, 2025

compiler-errors Mar 19, 2025

lcnr Apr 7, 2025

lcnr Mar 19, 2025

lcnr left a comment

craterbot commented Mar 19, 2025

compiler-errors commented Apr 7, 2025

bors commented Apr 7, 2025

Implement overflow for infinite implied lifetime bounds #138676

Implement overflow for infinite implied lifetime bounds #138676

Conversation

compiler-errors commented Mar 18, 2025 • edited by fmease Loading

compiler-errors commented Mar 18, 2025

bors commented Mar 18, 2025

fmease commented Mar 18, 2025 • edited Loading

bors commented Mar 18, 2025

compiler-errors commented Mar 18, 2025

This comment has been minimized.

craterbot commented Mar 18, 2025

craterbot commented Mar 18, 2025

rust-timer commented Mar 18, 2025

Overall result: no relevant changes - no action needed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcnr left a comment

Choose a reason for hiding this comment

craterbot commented Mar 19, 2025

compiler-errors commented Apr 7, 2025

bors commented Apr 7, 2025

compiler-errors commented Mar 18, 2025 •

edited by fmease

Loading

fmease commented Mar 18, 2025 •

edited

Loading