add naked_functions_rustic_abi feature gate
#139001
Open
+142
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
naked-function-rustic-abi
branch
from
354e101 to
fde1ca2
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
naked-function-rustic-abi
branch
from
fde1ca2 to
e10fa77
Compare
traviscross
force-pushed
the
naked-function-rustic-abi
branch
from
e10fa77 to
3513fa8
Compare
traviscross
reviewed
Apr 7, 2025
Comment on lines
-2833
to
-2864
| declare_lint! { | ||
| /// The `undefined_naked_function_abi` lint detects naked function definitions that | ||
| /// either do not specify an ABI or specify the Rust ABI. | ||
| /// | ||
| /// ### Example | ||
| /// | ||
| /// ```rust | ||
| /// #![feature(asm_experimental_arch, naked_functions)] | ||
| /// | ||
| /// use std::arch::naked_asm; | ||
| /// | ||
| /// #[naked] | ||
| /// pub fn default_abi() -> u32 { | ||
| /// unsafe { naked_asm!(""); } | ||
| /// } | ||
| /// | ||
| /// #[naked] | ||
| /// pub extern "Rust" fn rust_abi() -> u32 { | ||
| /// unsafe { naked_asm!(""); } | ||
| /// } | ||
| /// ``` | ||
| /// | ||
| /// {{produces}} | ||
| /// | ||
| /// ### Explanation | ||
| /// | ||
| /// The Rust ABI is currently undefined. Therefore, naked functions should | ||
| /// specify a non-Rust ABI. | ||
| pub UNDEFINED_NAKED_FUNCTION_ABI, | ||
| Warn, | ||
| "undefined naked function ABI" | ||
| } |
There was a problem hiding this comment.
Since this lint wasn't gated, it should be removed "properly" and marked as register_removed over in compiler/rustc_lint/src/lib.rs.
(Thanks to @compiler-errors for confirming this.)
|
This looks right in terms of what we asked for as a lang matter. With the requested change to remove the lint properly, the implementation looks reasonable to me, so please have a look and feel free to r? compiler-errors @rustbot author |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
folkertdev
force-pushed
the
naked-function-rustic-abi
branch
from
3513fa8 to
8866af3
Compare
|
I've added the @rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #138997
Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.
r? @traviscross