Reduce kw::Empty usage, part 5 #139848
Merged
Reduce kw::Empty usage, part 5 #139848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were low value even before rust-lang#137978 resulted in empty names being used much less. (Why check for non-emptiness in these three places? There are thousands of places in the compiler you could check.)
Field names are never empty, so the unwrap is unnecessary.
This is pretty weird code. As the `HACK` comment indicates, we push the empty ident here only to make the path longer, so certain checks to occur within `lint_if_path_starts_with_module`. `dummy` is a better choice because it explicitly communicates that the actual value doesn't matter.
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Apr 15, 2025
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138455 (`librustdoc`: more `impl fmt::Display`) - rust-lang#139818 (Normalize ADT field in `find_tails_for_unsizing`) - rust-lang#139819 (Use `rust-cache` to speed-up `citool` compilation) - rust-lang#139824 (Remove safe remove) - rust-lang#139848 ( Reduce kw::Empty usage, part 5) - rust-lang#139859 (CI: rename MacOS runner) - rust-lang#139877 (Add warning comment to `Take::get_ref` and `Chain::get_ref`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2025
Rollup merge of rust-lang#139848 - nnethercote:kw-Empty-5, r=compiler-errors Reduce kw::Empty usage, part 5 Another step towards rust-lang#137978. r? `@davidtwco`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #137978.
r? @davidtwco