Skip to content

document RUSTC_BOOTSTRAP, RUSTC_OVERRIDE_VERSION_STRING, and -Z allow-features in the unstable book #139885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

document RUSTC_BOOTSTRAP, RUSTC_OVERRIDE_VERSION_STRING, and -Z allow-features in the unstable book #139885

merged 1 commit into from
Apr 17, 2025
+109 −0

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 15, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2025
@jyn514 jyn514 mentioned this pull request Apr 15, 2025
Open
3 tasks
@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch from 4ef62af to c805e9a Compare April 15, 2025 21:04
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch 2 times, most recently from 045a310 to 30b9f70 Compare April 15, 2025 22:10
@jyn514 jyn514 changed the title document RUSTC_BOOTSTRAP in the unstable book document RUSTC_BOOTSTRAP and -Z allow-features in the unstable book Apr 15, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
ojeda
ojeda reviewed Apr 15, 2025
View reviewed changes
src/doc/unstable-book/src/compiler-flags/rustc-bootstrap.md Outdated
That constraint was later relaxed; see <https://github.com/rust-lang/rust/issues/36548> for the discussion that happened at that time.

People have at various times proposed re-adding the technical constraints.
However, doing so is extremely disruptive for several major projects that we very much want to keep using the latest toolchain versions, such as Firefox, Rust for Linux, and Chromium.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the following means:

that we very much want to keep using the latest toolchain versions

Is it meant to refer to the stable releases?

Copy link
Member Author

@jyn514 jyn514 Apr 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, exactly. my opinion is that any kind of technical constraint around RUSTC_BOOTSTRAP either forces projects to pin an old version of stable, which is bad for all parties involved, or is just ineffective.

i will try to find a better way to word this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense, thanks!

@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch 3 times, most recently from f70b8b9 to 1a0cc37 Compare April 16, 2025 03:41
@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch from a239539 to 1a3bea9 Compare April 16, 2025 04:05
@jieyouxu jieyouxu added A-stability Area: `#[stable]`, `#[unstable]` etc. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Apr 16, 2025
@jyn514 jyn514 changed the title document RUSTC_BOOTSTRAP and -Z allow-features in the unstable book document RUSTC_BOOTSTRAP, RUSTC_OVERRIDE_VERSION_STRING, and -Z allow-features in the unstable book Apr 16, 2025
@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch from e6303b8 to 9cd5f53 Compare April 16, 2025 12:03
@jyn514 jyn514 mentioned this pull request Apr 16, 2025
Open
ojeda
ojeda reviewed Apr 16, 2025
View reviewed changes
src/doc/unstable-book/src/compiler-flags/rustc-override-version-string.md
rustc 1.81.0-nightly
```

Note that the version string is completely overwritten; i.e. rustc discards commit hash and commit date information unless it is explicitly included in the environment variable. The string only applies to the "release" part of the version; for example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is clear enough thanks to the examples, but when I saw "completely" I thought it also meant the rustc part, so I double-checked with an extreme example, e.g.

$ RUSTC_OVERRIDE_VERSION_STRING=! rustc --version
rustc !

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch from 9cd5f53 to beac1d0 Compare April 16, 2025 13:22
@jieyouxu jieyouxu added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2025
@Nadrieril
Copy link
Member

Looks good, r=me once you feel like you've addressed the remaining review comments.

@jyn514 jyn514 force-pushed the doc-rustc-bootstrap branch from beac1d0 to a114bcf Compare April 17, 2025 00:18
@clubby789
Copy link
Contributor

@bors r=Nadrieril

@bors
Copy link
Collaborator

bors commented Apr 17, 2025

📌 Commit a114bcf has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 17, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 17, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
@bors
Auto merge of rust-lang#139949 - matthiaskrgr:rollup-pxc5tsx, r=matth…
883f9f7 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138632 (Stabilize `cfg_boolean_literals`)
 - rust-lang#139416 (unstable book; document `macro_metavar_expr_concat`)
 - rust-lang#139782 (Consistent with treating Ctor Call as Struct in liveness analysis)
 - rust-lang#139885 (document RUSTC_BOOTSTRAP, RUSTC_OVERRIDE_VERSION_STRING, and -Z allow-features in the unstable book)
 - rust-lang#139904 (Explicitly annotate edition for `unpretty=expanded` and `unpretty=hir` tests)
 - rust-lang#139932 (transmutability: Refactor tests for simplicity)
 - rust-lang#139944 (Move eager translation to a method on Diag)
 - rust-lang#139948 (git: ignore `60600a6fa403216bfd66e04f948b1822f6450af7` for blame purposes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4e2fc09 into rust-lang:master Apr 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
@rust-timer
Unrolled build for rust-lang#139885
9a61182 
Rollup merge of rust-lang#139885 - jyn514:doc-rustc-bootstrap, r=Nadrieril

document RUSTC_BOOTSTRAP, RUSTC_OVERRIDE_VERSION_STRING, and -Z allow-features in the unstable book

[rendered](https://github.com/jyn514/rust/blob/doc-rustc-bootstrap/src/doc/unstable-book/src/compiler-flags/rustc-bootstrap.md)
mcp: rust-lang/compiler-team#863
@jyn514 jyn514 deleted the doc-rustc-bootstrap branch April 17, 2025 14:45
@jieyouxu jieyouxu removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeda ojeda ojeda left review comments

@aDotInTheVoid aDotInTheVoid aDotInTheVoid left review comments

@jieyouxu jieyouxu jieyouxu left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Nadrieril Nadrieril

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-stability Area: `#[stable]`, `#[unstable]` etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
10 participants
@jyn514 @rustbot @rust-log-analyzer @Nadrieril @clubby789 @bors @ojeda @Mark-Simulacrum @aDotInTheVoid @jieyouxu