[win][CI] Convert paths to Windows format before adding to PATH #140754

dpaoliello · 2025-05-07T17:44:04Z

While trying to get the aarch64-msvc build working correctly (#140136), I noticed that the PATH observed during the Rust steps of the build on Windows builds had some entries still in MinGW format, which means that Windows would not be able to use them correctly:

From https://github.com/rust-lang/rust/actions/runs/14606167901/job/40975555680#step:28:192 note the path for ninja and sccache.

PATH = Some(C:\a\rust\rust\src\ci\citool\../../../build/citool\debug\deps;C:\a\rust\rust\src\ci\citool\../../../build/citool\debug;C:\Users\runneradmin\.rustup\toolchains\stable-aarch64-pc-windows-msvc\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files\Git\clangarm64/bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;/c/a/rust/rust/ninja;/c/a/rust/rust/sccache;C:\Users\runneradmin/.cargo/bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS\;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver\;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files (x86)\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files\Microsoft SQL Server\160\DTS\Binn\;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps)

The fix for this is to use cygpath to convert from the Cygwin format back to native Windows format before adding to the PATH.

try-job: dist-aarch64-msvc
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-i686-mingw

rustbot · 2025-05-07T17:44:10Z

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

marcoieni · 2025-05-12T15:35:12Z

src/ci/scripts/install-mingw.sh

@@ -42,5 +42,5 @@ if isWindows && isKnownToBeMingwBuild; then

    curl -o mingw.7z "${MIRRORS_BASE}/${mingw_archive}"
    7z x -y mingw.7z > /dev/null
-    ciCommandAddPath "$(pwd)/${mingw_dir}/bin"
+    ciCommandAddPath "$(cygpath -m "$(pwd)/${mingw_dir}/bin")"


this change is useful for non-mingw builds, but this line runs only in mingw builds (see isKnownToBeMingwBuild in the if).

Is this still useful in your opinion? 🤔

Yes, it is still useful.

Even though this is a MinGW build, we are not running the MinGW versions of all of the tools. For example, we are still using a native Windows Rust toolchain, and it is using native Windows paths (for example: https://github.com/rust-lang-ci/rust/actions/runs/14918934614/job/41910551227#step:27:214).

marcoieni · 2025-05-12T16:08:17Z

the rest of the pr looks good to me. Let's just run a bors try to check that the CI keeps working 👍

dpaoliello · 2025-05-12T16:38:29Z

the rest of the pr looks good to me. Let's just run a bors try to check that the CI keeps working 👍

Sure: but I don't have permissions to run try...

marcoieni · 2025-05-13T12:59:22Z

If you list the jobs you want to test I can kick off the try build 👍

dpaoliello · 2025-05-13T16:52:11Z

If you list the jobs you want to test I can kick off the try build 👍

Done, ready to try!

marcoieni · 2025-05-14T10:24:38Z

@bors try

[win][CI] Convert paths to Windows format before adding to PATH While trying to get the `aarch64-msvc` build working correctly (rust-lang#140136), I noticed that the `PATH` observed during the Rust steps of the build on Windows builds had some entries still in MinGW format, which means that Windows would not be able to use them correctly: From <https://github.com/rust-lang/rust/actions/runs/14606167901/job/40975555680#step:28:192> note the path for `ninja` and `sccache`. ``` PATH = Some(C:\a\rust\rust\src\ci\citool\../../../build/citool\debug\deps;C:\a\rust\rust\src\ci\citool\../../../build/citool\debug;C:\Users\runneradmin\.rustup\toolchains\stable-aarch64-pc-windows-msvc\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files\Git\clangarm64/bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;/c/a/rust/rust/ninja;/c/a/rust/rust/sccache;C:\Users\runneradmin/.cargo/bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS\;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver\;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files (x86)\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files\Microsoft SQL Server\160\DTS\Binn\;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps) ``` The fix for this is to use `cygpath` to convert from the Cygwin format back to native Windows format before adding to the `PATH`. --- try-job: dist-aarch64-msvc try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: dist-i686-mingw

bors · 2025-05-14T10:50:18Z

⌛ Trying commit bff023d with merge 758dfd4...

bors · 2025-05-14T12:44:43Z

💔 Test failed - checks-actions

dpaoliello · 2025-05-14T17:03:20Z

@marcoieni can we please retry, looks like the builder was out of space

marcoieni · 2025-05-15T08:58:24Z

Yes, there's an issue with windows runners right now.
See https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Mysterious.20full.20merge.20failures/near/518239969
If #141023 is merged, you can merge with master and we can try again

marcoieni · 2025-05-15T13:45:54Z

the PR was merged, so you can rebase and I can run the try again 👍

dpaoliello · 2025-05-15T16:50:17Z

the PR was merged, so you can rebase and I can run the try again 👍

Rebased and ready to go!

marcoieni · 2025-05-15T20:55:56Z

@bors try

[win][CI] Convert paths to Windows format before adding to PATH While trying to get the `aarch64-msvc` build working correctly (rust-lang#140136), I noticed that the `PATH` observed during the Rust steps of the build on Windows builds had some entries still in MinGW format, which means that Windows would not be able to use them correctly: From <https://github.com/rust-lang/rust/actions/runs/14606167901/job/40975555680#step:28:192> note the path for `ninja` and `sccache`. ``` PATH = Some(C:\a\rust\rust\src\ci\citool\../../../build/citool\debug\deps;C:\a\rust\rust\src\ci\citool\../../../build/citool\debug;C:\Users\runneradmin\.rustup\toolchains\stable-aarch64-pc-windows-msvc\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files\Git\clangarm64/bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;/c/a/rust/rust/ninja;/c/a/rust/rust/sccache;C:\Users\runneradmin/.cargo/bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS\;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver\;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files (x86)\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files\Microsoft SQL Server\160\DTS\Binn\;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps) ``` The fix for this is to use `cygpath` to convert from the Cygwin format back to native Windows format before adding to the `PATH`. --- try-job: dist-aarch64-msvc try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: dist-i686-mingw

bors · 2025-05-15T20:57:08Z

⌛ Trying commit e71deaa with merge ddcd73a...

bors · 2025-05-15T23:41:43Z

☀️ Try build successful - checks-actions
Build commit: ddcd73a (ddcd73a3013aa72ffe290dbfbdda7acb63483edc)

marcoieni · 2025-05-16T09:28:39Z

Are the new paths what you expect?

dpaoliello · 2025-05-16T16:53:08Z

Yep, looks good to me

marcoieni · 2025-05-19T08:59:33Z

@bors r+

bors · 2025-05-19T08:59:36Z

📌 Commit e71deaa has been approved by marcoieni

It is now in the queue for this repository.

bors · 2025-05-19T09:51:34Z

⌛ Testing commit e71deaa with merge 7068c8b...

bors · 2025-05-19T12:58:24Z

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing 7068c8b to master...

github-actions · 2025-05-19T13:01:07Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f292ee (parent) -> 7068c8b (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7068c8bd81c73db264c544f75a43158555567848 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 7253.4s -> 9070.2s (25.0%)
dist-x86_64-apple: 7915.8s -> 8904.6s (12.5%)
dist-apple-various: 6215.8s -> 6818.3s (9.7%)
x86_64-apple-2: 5083.8s -> 4641.7s (-8.7%)
dist-various-1: 4475.1s -> 4842.1s (8.2%)
dist-loongarch64-musl: 5327.8s -> 5688.7s (6.8%)
dist-aarch64-linux: 5324.6s -> 5641.7s (6.0%)
dist-aarch64-apple: 5318.2s -> 5623.5s (5.7%)
dist-x86_64-mingw: 8065.6s -> 7640.0s (-5.3%)
x86_64-gnu-stable: 6682.4s -> 7001.4s (4.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-19T14:29:50Z

Finished benchmarking commit (7068c8b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.8%	[5.8%, 5.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.3%, -0.4%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.7%, -0.4%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.359s -> 774.989s (-0.05%)
Artifact size: 365.57 MiB -> 365.51 MiB (-0.02%)

rustbot assigned marcoieni May 7, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 7, 2025

marcoieni reviewed May 12, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025

[win][CI] Convert paths to Windows format before adding to PATH

e71deaa

dpaoliello force-pushed the cygwinpath branch from bff023d to e71deaa Compare May 15, 2025 16:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 19, 2025

bors merged commit 7068c8b into rust-lang:master May 19, 2025
7 checks passed

rustbot added this to the 1.89.0 milestone May 19, 2025

dpaoliello deleted the cygwinpath branch May 19, 2025 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[win][CI] Convert paths to Windows format before adding to PATH #140754

[win][CI] Convert paths to Windows format before adding to PATH #140754

dpaoliello commented May 7, 2025 •

edited

Loading

rustbot commented May 7, 2025

marcoieni May 12, 2025

dpaoliello May 12, 2025

marcoieni commented May 12, 2025

dpaoliello commented May 12, 2025

marcoieni commented May 13, 2025

dpaoliello commented May 13, 2025

marcoieni commented May 14, 2025

bors commented May 14, 2025

This comment has been minimized.

bors commented May 14, 2025

dpaoliello commented May 14, 2025

marcoieni commented May 15, 2025

marcoieni commented May 15, 2025

dpaoliello commented May 15, 2025

marcoieni commented May 15, 2025

bors commented May 15, 2025

bors commented May 15, 2025

marcoieni commented May 16, 2025

dpaoliello commented May 16, 2025

marcoieni commented May 19, 2025

bors commented May 19, 2025

bors commented May 19, 2025

bors commented May 19, 2025

github-actions bot commented May 19, 2025

rust-timer commented May 19, 2025

[win][CI] Convert paths to Windows format before adding to PATH #140754

[win][CI] Convert paths to Windows format before adding to PATH #140754

Conversation

dpaoliello commented May 7, 2025 • edited Loading

rustbot commented May 7, 2025

marcoieni May 12, 2025

Choose a reason for hiding this comment

dpaoliello May 12, 2025

Choose a reason for hiding this comment

marcoieni commented May 12, 2025

dpaoliello commented May 12, 2025

marcoieni commented May 13, 2025

dpaoliello commented May 13, 2025

marcoieni commented May 14, 2025

bors commented May 14, 2025

This comment has been minimized.

bors commented May 14, 2025

dpaoliello commented May 14, 2025

marcoieni commented May 15, 2025

marcoieni commented May 15, 2025

dpaoliello commented May 15, 2025

marcoieni commented May 15, 2025

bors commented May 15, 2025

bors commented May 15, 2025

marcoieni commented May 16, 2025

dpaoliello commented May 16, 2025

marcoieni commented May 19, 2025

bors commented May 19, 2025

bors commented May 19, 2025

bors commented May 19, 2025

github-actions bot commented May 19, 2025

Test differences

Job duration changes

rust-timer commented May 19, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

dpaoliello commented May 7, 2025 •

edited

Loading