impl PartialEq<{str,String}> for {Path,PathBuf}
#140956
Open
+71
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
44bb04c to
90838cd
Compare
This comment has been minimized.
This comment has been minimized.
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
90838cd to
c7d5b49
Compare
This comment has been minimized.
This comment has been minimized.
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
c7d5b49 to
f908d17
Compare
This comment has been minimized.
This comment has been minimized.
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
f908d17 to
aab1563
Compare
|
r? libs-api |
rustbot
added
the
T-libs-api
|
Starting a crater run since we've previously had type inference issues with @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2025
… r=<try>
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
|
☀️ Try build successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os
PartialEqbetween strings and paths, both owned and unsized, in both directions.ACP: rust-lang/libs-team#151