Tracking the old name of renamed unstable library features #142158

xizheyin · 2025-06-07T11:04:05Z

This PR resolves the first problem of #141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification.

r? @jdonszelmann
There have been a lot of PR's reviewed by you lately, thanks for your time!

cc @jyn514

Signed-off-by: xizheyin <[email protected]>

rustbot · 2025-06-07T11:04:10Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-06-07T11:04:13Z

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

xizheyin · 2025-06-07T11:10:27Z

compiler/rustc_passes/src/stability.rs

-        for (feature, since) in defined_features.to_sorted_vec() {
-            if let FeatureStability::AcceptedSince(since) = since
+        for (feature, stability) in defined_features.to_sorted_vec() {
+            if let FeatureStability::AcceptedSince(since) = stability


Naming it since is not accurate here, the attribute here may be unstable. So I renamed it to stability.

xizheyin · 2025-06-07T11:16:03Z

compiler/rustc_passes/src/stability.rs

+            if let FeatureStability::Unstable(Some(alias)) = stability {
+                if let Some(span) = remaining_lib_features.swap_remove(&alias) {
+                    tcx.dcx().emit_err(errors::RenamedFeature { span, feature, alias });
+                }
+            }
+


In check_features, check if any of the defined features have alias the same as the #![feature(...)]-declared feature, and if they do, remove them and issue an error. This way, it won't issue the unknown features error later.

xizheyin · 2025-06-07T11:18:49Z

library/core/src/ops/control_flow.rs

@@ -98,7 +98,7 @@ pub enum ControlFlow<B, C = ()> {
    // is a no-op conversion in the `Try` implementation.
 }

-#[unstable(feature = "try_trait_v2", issue = "84277")]
+#[unstable(feature = "try_trait_v2", issue = "84277", alias = "try_trait")]


I'm currently using try_trait as an example, I'm trying to find out what other features have been renamed in the standard library, I also found slice_internals_v2, but that may not be enough.

alias has been replaced with old_name.

Noratrieb · 2025-06-07T12:21:26Z

library/core/src/ops/try_trait.rs

@@ -112,7 +112,7 @@ use crate::ops::ControlFlow;
 ///     R::from_output(accum)
 /// }
 /// ```
-#[unstable(feature = "try_trait_v2", issue = "84277")]
+#[unstable(feature = "try_trait_v2", issue = "84277", alias = "try_trait")]


I think "alias" is a bit misleading. It's not an alias that can be used, it's the previous name that can no longer be used. I'd call it previous_name or something like that to make it clear what it is.

Thanks for advice, I change it to old_name, which would be shorter than previous_name and presents the same meaning.

jdonszelmann · 2025-06-12T10:39:19Z

compiler/rustc_middle/src/middle/mod.rs

@@ -12,7 +12,7 @@ pub mod lib_features {
    #[derive(HashStable, TyEncodable, TyDecodable)]
    pub enum FeatureStability {
        AcceptedSince(Symbol),
-        Unstable,
+        Unstable(Option<Symbol>),


it's nicer I think if this is a named variant with old_name in it. I wouldn't know what this meant otherwise. AcceptedSince is clearer in that regard so is fine staying the way it is. Ping me after that and I'll r+ @rusbot author

jdonszelmann · 2025-06-12T10:53:03Z

@rustbot author

rustbot · 2025-06-12T10:53:06Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Signed-off-by: xizheyin <[email protected]>

xizheyin · 2025-06-12T11:25:46Z

I revised it. 😊 @jdonszelmann
@rustbot ready

jdonszelmann · 2025-06-12T12:39:37Z

@bors r+ rollup

bors · 2025-06-12T12:39:40Z

📌 Commit b8066f9 has been approved by jdonszelmann

It is now in the queue for this repository.

Rollup of 10 pull requests Successful merges: - #134847 (Implement asymmetrical precedence for closures and jumps) - #141491 (Delegate `<CStr as Debug>` to `ByteStr`) - #141770 (Merge `Cfg::render_long_html` and `Cfg::render_long_plain` methods common code) - #142069 (Introduce `-Zmacro-stats`) - #142158 (Tracking the old name of renamed unstable library features) - #142221 ([AIX] strip underlying xcoff object) - #142340 (miri: we can use apfloat's mul_add now) - #142379 (Add bootstrap option to compile a tool with features) - #142410 (intrinsics: rename min_align_of to align_of) - #142413 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142158 - xizheyin:141617, r=jdonszelmann Tracking the old name of renamed unstable library features This PR resolves the first problem of #141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification. r? `@jdonszelmann` There have been a lot of PR's reviewed by you lately, thanks for your time! cc `@jyn514`

Rollup of 10 pull requests Successful merges: - rust-lang/rust#134847 (Implement asymmetrical precedence for closures and jumps) - rust-lang/rust#141491 (Delegate `<CStr as Debug>` to `ByteStr`) - rust-lang/rust#141770 (Merge `Cfg::render_long_html` and `Cfg::render_long_plain` methods common code) - rust-lang/rust#142069 (Introduce `-Zmacro-stats`) - rust-lang/rust#142158 (Tracking the old name of renamed unstable library features) - rust-lang/rust#142221 ([AIX] strip underlying xcoff object) - rust-lang/rust#142340 (miri: we can use apfloat's mul_add now) - rust-lang/rust#142379 (Add bootstrap option to compile a tool with features) - rust-lang/rust#142410 (intrinsics: rename min_align_of to align_of) - rust-lang/rust#142413 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2025-06-18T08:20:34Z

diagnosing #142442

@rust-timer build df23987

rust-timer · 2025-06-18T10:33:21Z

Finished benchmarking commit (df23987): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	10
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	21
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	0.2%	[0.1%, 0.3%]	10

Max RSS (memory usage)

Results (primary -1.3%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.2%, 2.2%]	4
Improvements ✅ (primary)	-1.3%	[-1.7%, -0.7%]	3
Improvements ✅ (secondary)	-3.9%	[-4.9%, -3.1%]	3
All ❌✅ (primary)	-1.3%	[-1.7%, -0.7%]	3

Cycles

Results (primary 1.3%, secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.9%, -2.2%]	2
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.993s -> 689.634s (-8.66%)
Artifact size: 372.27 MiB -> 372.27 MiB (0.00%)

xizheyin · 2025-06-18T10:51:26Z

This may be in line with expectations?

Kobzol · 2025-06-18T13:36:27Z

Thanks Jubilee (wouldn't guess this one). Yeah, I guess that since this does more work, a small regression on doc benchmarks is fine.

Tracking the old name of renamed unstable library features This PR resolves the first problem of rust-lang#141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification. r? `@jdonszelmann` There have been a lot of PR's reviewed by you lately, thanks for your time! cc `@jyn514`

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#134847 (Implement asymmetrical precedence for closures and jumps) - rust-lang#141491 (Delegate `<CStr as Debug>` to `ByteStr`) - rust-lang#141770 (Merge `Cfg::render_long_html` and `Cfg::render_long_plain` methods common code) - rust-lang#142069 (Introduce `-Zmacro-stats`) - rust-lang#142158 (Tracking the old name of renamed unstable library features) - rust-lang#142221 ([AIX] strip underlying xcoff object) - rust-lang#142340 (miri: we can use apfloat's mul_add now) - rust-lang#142379 (Add bootstrap option to compile a tool with features) - rust-lang#142410 (intrinsics: rename min_align_of to align_of) - rust-lang#142413 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Add test renamed_feature.rs

8eeaed0

Signed-off-by: xizheyin <[email protected]>

rustbot assigned jdonszelmann Jun 7, 2025

xizheyin changed the title ~~141617~~ Tracking the old name of renamed unstable library attribute Jun 7, 2025

xizheyin changed the title ~~Tracking the old name of renamed unstable library attribute~~ Tracking the old name of renamed unstable library features Jun 7, 2025

xizheyin commented Jun 7, 2025

View reviewed changes

Noratrieb reviewed Jun 7, 2025

View reviewed changes

xizheyin force-pushed the 141617 branch from 6c9a2e2 to 881fafc Compare June 7, 2025 14:25

jdonszelmann reviewed Jun 12, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025

Tracking the old name of renamed unstable library attribute

b8066f9

Signed-off-by: xizheyin <[email protected]>

xizheyin force-pushed the 141617 branch from 881fafc to b8066f9 Compare June 12, 2025 11:24

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025

matthiaskrgr mentioned this pull request Jun 13, 2025

Rollup of 10 pull requests #142442

Merged

bors merged commit fac011e into rust-lang:master Jun 13, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 13, 2025

xizheyin deleted the 141617 branch June 13, 2025 14:51

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jun 18, 2025

Tracking the old name of renamed unstable library features #142158

Tracking the old name of renamed unstable library features #142158

Uh oh!

Conversation

xizheyin commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 7, 2025

Uh oh!

rustbot commented Jun 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Jun 12, 2025

Uh oh!

rustbot commented Jun 12, 2025

Uh oh!

xizheyin commented Jun 12, 2025

Uh oh!

jdonszelmann commented Jun 12, 2025

Uh oh!

bors commented Jun 12, 2025

Uh oh!

Uh oh!

workingjubilee commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-timer commented Jun 18, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

xizheyin commented Jun 18, 2025

Uh oh!

Kobzol commented Jun 18, 2025

Uh oh!

Uh oh!

xizheyin commented Jun 7, 2025 •

edited

Loading

workingjubilee commented Jun 18, 2025 •

edited

Loading