Skip to content

intrinsics: rename min_align_of to align_of #142410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

intrinsics: rename min_align_of to align_of #142410

merged 1 commit into from
Jun 13, 2025
+73 −87

Conversation

RalfJung
Copy link
Member

Now that pref_align_of is gone (#141803), we can give the intrinsic backing align_of its proper name.

r? @workingjubilee or @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2025

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

RalfJung
RalfJung commented Jun 12, 2025
View reviewed changes
library/core/src/mem/mod.rs
Comment on lines -640 to -641
#[allow(deprecated_in_future)]
#[allow(deprecated)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed these unnecessary allow(deprecated) while grepping through the file, and removed them as a drive-by fix.

@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

📌 Commit f6db2bc has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025
@WaffleLapkin WaffleLapkin mentioned this pull request Jun 12, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Jun 12, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2025
@RalfJung
Copy link
Member Author

So what is "init" or "extra"? That panic message is not very helpful.^^

Seems to have been added in #138682, Cc @Alexendoo

@RalfJung
Copy link
Member Author

RalfJung commented Jun 12, 2025 •
edited
Loading

From the context of that PR, it seems that now adding more symbols to the rustc symbol list can cause clippy to panic or so. That feels fragile, does it have to be that way...?

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the align_of branch 2 times, most recently from 31770ea to d96b75e Compare June 12, 2025 14:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

what an odd thing.

@workingjubilee
Copy link
Member

@bors r=WaffleLapkin,workingjubilee

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

📌 Commit 62418f4 has been approved by WaffleLapkin,workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2025
@Alexendoo
Copy link
Member

From the context of that PR, it seems that now adding more symbols to the rustc symbol list can cause clippy to panic or so. That feels fragile, does it have to be that way...?

I'll take a look at improving that

@RalfJung
Copy link
Member Author

Thanks!

For now, I have made the panic message a bit more clear.

@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2025
Merged
bors added a commit that referenced this pull request Jun 13, 2025
@bors
Auto merge of #142442 - matthiaskrgr:rollup-6yodjfx, r=matthiaskrgr
c359117 
Rollup of 10 pull requests

Successful merges:

 - #134847 (Implement asymmetrical precedence for closures and jumps)
 - #141491 (Delegate `<CStr as Debug>` to `ByteStr`)
 - #141770 (Merge `Cfg::render_long_html` and `Cfg::render_long_plain` methods common code)
 - #142069 (Introduce `-Zmacro-stats`)
 - #142158 (Tracking the old name of renamed unstable library features)
 - #142221 ([AIX] strip underlying xcoff object)
 - #142340 (miri: we can use apfloat's mul_add now)
 - #142379 (Add bootstrap option to compile a tool with features)
 - #142410 (intrinsics: rename min_align_of to align_of)
 - #142413 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 86e9995 into rust-lang:master Jun 13, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 13, 2025
rust-timer added a commit that referenced this pull request Jun 13, 2025
@rust-timer
Unrolled build for #142410
309f1c5 
Rollup merge of #142410 - RalfJung:align_of, r=WaffleLapkin,workingjubilee

intrinsics: rename min_align_of to align_of

Now that `pref_align_of` is gone (#141803), we can give the intrinsic backing `align_of` its proper name.

r? `@workingjubilee` or `@bjorn3`
@RalfJung RalfJung deleted the align_of branch June 13, 2025 14:43
@carolynzech carolynzech mentioned this pull request Jun 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
8 participants
@RalfJung @rustbot @WaffleLapkin @bors @rust-log-analyzer @oli-obk @workingjubilee @Alexendoo