-
Notifications
You must be signed in to change notification settings - Fork 13.4k
libcollections: Add a Multiset data structure. #15623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c21a9b6
Add a Multiset trait and an implementation of that trait based on Tre…
nham 0976d47
Change difference/symmetric-differenc/intersection/union iterators to…
nham 2d22dcf
Various additions.
nham b527a30
Change TreeMultiset len() to return the number of occurrences. The pr…
nham 48add65
Make TreeMultiset.extend() use insert_one
nham 4592fdc
Add sum operation to TreeMultiset
nham d7c2a91
Add test_from_iter to TreeMultiset
nham ac30b87
Rename [insert|remove]_one to [insert|remove] and [insert|remove] to …
nham 8bdcb1b
Make TreeMultiset implement Hash
nham 3e7c70b
Remove the Multiset and MutableMultiset traits.
nham dce9de8
Implement lower_bound and upper_bound
nham 05aa1f3
Remove trailing whitespace, duplicate function definition.
nham 3af7a28
Inline a bunch of methods. Change one 0u -> 0
nham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not also have remove_one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inadvertent omission. I've just added it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a minor point, but it seems like insert_one/remove_one are probably the more common methods for someone to want. Would it be better to have insert/remove be insert_one/remove_one, and then have insert_many/remove_many? At very least, this would bring the multiset interface superficially closer to the set interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. Most of the inserts/removes will probably be one at a time. I'll change this.