The Advanced Rust Programming Language #27032
Conversation
Fix description of integer conversions
Tiny typo of "positive"
fix double "however"
This worked fine on github but isn't displayed as a bulleted list on http://www.cglab.ca/~abeinges/blah/turpl/concurrency.html#send-and-sync
extra whitespace to render *-list as list
|
@gankro I reviewed nearly everything up through the "Uninitialized Memory" chapter. Not sure if I'll get to the rest any time soon, but I'm sure my comments on those parts can wait. |
|
Ownership paths are not a language concept. They are not relevant to safety (except as they help you avoid double-frees), not relevant to |
| // need to last for the whole scope x is valid for. The return | ||
| // of as_str must find a str somewhere *before* this function | ||
| // call. Obviously not happening. | ||
| println!("{}", as_str::<'d>(&'d temp)); |
There was a problem hiding this comment.
//~^ ERROR unresolved name temp. Did you mean x?
|
References.md is now the only major outstanding issue. Everything else I believe can be handled after landing this (omg I want to land this) I'm tempted to just tear out references.md as temporary measure. |
|
@bors r=aturon,acrichto,arielb,pnkfelix,nrc,nmatsakis,huonw LETS DO THIS |
|
📌 Commit 4c48ffa has been approved by |
|
\o/ congrats! this is amazing work. |
|
🎊 |
|
⌛ Testing commit 4c48ffa with merge f1ba1fd... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors r=aturon,acrichto,arielb,pnkfelix,nrc,nmatsakis,huonw |
|
📌 Commit ddb0290 has been approved by |
…x,nrc,nmatsakis,huonw I've been baking this out of tree for long enough. This is currently about ~2/5ths the size of TRPL. Time to get it in tree so it can be more widely maintained and scrutinized. I've preserved the whole gruesome history including various rewrites. I can definitely squash these a fair amount if desired. Some random people submitted minor fixes though, so they're mixed in. Edit: forgot to link to rendered http://cglab.ca/~abeinges/blah/turpl/_book/ Edit2: To streamline the review process, I'm going to break this into sections that need official "domain expert" approval: # Summary * [ ] references.md -- very important, needs work * [x] Meet Safe and Unsafe: reviewed by @aturon * [x] Data Layout: reviewed by @arielb1 * [x] Ownership: reviewed by @aturon ( and sorta @nikomatsakis ) -- significantly updated, may need re-r * [x] Coversions: reviewed by @nrc * [x] Uninitialized Memory: reviewed by @pnkfelix * [x] Ownership-Oriented Resource Management: reviewed by @aturon * [x] Unwinding: reviewed by @alexcrichton * [x] Concurrency: reviewed by @aturon * [x] Implementing Vec: r? @huonw
|
someone forgot to squash :( |
I've been baking this out of tree for long enough. This is currently about ~2/5ths the size of TRPL. Time to get it in tree so it can be more widely maintained and scrutinized. I've preserved the whole gruesome history including various rewrites. I can definitely squash these a fair amount if desired. Some random people submitted minor fixes though, so they're mixed in.
Edit: forgot to link to rendered http://cglab.ca/~abeinges/blah/turpl/_book/
Edit2:
To streamline the review process, I'm going to break this into sections that need official "domain expert" approval:
Summary