Ignore the test added in #31717 #31771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang#31717 we rebased our LLVM fork over the 3.8 release branch, and it was thought that this fixed rust-lang#31702. The testing, however, must have been erroneous, as it unfortunately didn't fix the issue! Our MUSL nightly builders are failing from the same assertion reported in the issue, so we at least know the test case is a reproduction! I believe the failure is only happening on the MUSL nightly builders because none of the auto builders have LLVM assertions enabled, and the Linux nightly builder *does* have assertions enabled for the binaries we generate but the distcheck run doesn't test a compiler with LLVM assertions enabled.
|
@bors r+ p=1 |
|
📌 Commit d835f5b has been approved by |
|
⌛ Testing commit d835f5b with merge f2dda4a... |
|
💔 Test failed - auto-linux-32-opt |
|
@bors: retry On Fri, Feb 19, 2016 at 4:19 PM, bors [email protected] wrote:
|
bors
added a commit
that referenced
this pull request
Feb 20, 2016
…rson In #31717 we rebased our LLVM fork over the 3.8 release branch, and it was thought that this fixed #31702. The testing, however, must have been erroneous, as it unfortunately didn't fix the issue! Our MUSL nightly builders are failing from the same assertion reported in the issue, so we at least know the test case is a reproduction! I believe the failure is only happening on the MUSL nightly builders because none of the auto builders have LLVM assertions enabled, and the Linux nightly builder *does* have assertions enabled for the binaries we generate but the distcheck run doesn't test a compiler with LLVM assertions enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #31717 we rebased our LLVM fork over the 3.8 release branch, and it was
thought that this fixed #31702. The testing, however, must have been erroneous,
as it unfortunately didn't fix the issue! Our MUSL nightly builders are failing
from the same assertion reported in the issue, so we at least know the test case
is a reproduction!
I believe the failure is only happening on the MUSL nightly builders because
none of the auto builders have LLVM assertions enabled, and the Linux nightly
builder does have assertions enabled for the binaries we generate but the
distcheck run doesn't test a compiler with LLVM assertions enabled.