-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix silent overflows on Step
impls
#36365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f6c4fcf
fix silent overflows on `Step` impls
matthew-piziak 19fd7fc
add run-fail tests
matthew-piziak 065bf4b
remove non-run-fail tests
matthew-piziak dc607de
use UFCS with Add::add and Sub::sub instead of unstable attributes
matthew-piziak a802ec1
Merge branch 'silent-overflow' of github.com:matthew-piziak/rust into…
matthew-piziak dba6678
replace MIN/MAX constants with min_value/max_value functions
matthew-piziak db1e85d
remove erroneous semicolons
matthew-piziak cb26d55
unpwrap iterators in tests
matthew-piziak 2b4c778
Merge branch 'silent-overflow' of https://github.com/matthew-piziak/r…
matthew-piziak dd6e8c5
move overflow tests from rust-fail to run-pass
matthew-piziak 8f19d5c
add max value from iterator
matthew-piziak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// compile-flags: -C debug_assertions=yes | ||
|
||
use std::panic; | ||
|
||
fn main() { | ||
let r = panic::catch_unwind(|| { | ||
let mut it = u8::MAX..; | ||
it.next(); | ||
}); | ||
assert!(r.is_err()); | ||
|
||
let r = panic::catch_unwind(|| { | ||
let mut it = i8::MAX..; | ||
it.next(); | ||
}); | ||
assert!(r.is_err()); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// compile-flags: -C debug_assertions=no | ||
|
||
fn main() { | ||
let mut it = u8::MAX..; | ||
assert_eq!(it.next(), u8::MIN); | ||
|
||
let mut it = i8::MAX..; | ||
assert_eq!(it.next(), i8::MIN); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add::add(*self, 1)
is what @alexcrichton meant. Similar situation on the rest.