add modifier keyword spans to hir::Visibility; improve unreachable-pub, private-no-mangle lint suggestions#51866

Merged

bors merged 7 commits intorust-lang:masterfrom

zackmdavis:hir_making_each_day_of_the_year

Jul 2, 2018

Commits on Jul 1, 2018

choose a less arbitrary span when parsing the empty visibility modifier
zackmdavis
committed
in which hir::Visibility recalls whence it came (i.e., becomes Spanned)
zackmdavis
committed
unreachable_pub lint: grab `pub` span from HIR rather than inferring it
zackmdavis
committed
private no-mangle lints: issue suggestion for restricted visibility
zackmdavis
committed
private no-mangle lints: help hint note if visibility modifier is `pub`
zackmdavis
committed
in which the private/restricted-in-public error messaging gets specific
zackmdavis
committed
call it `hir::VisibilityKind` instead of `hir::Visibility_:*`
zackmdavis
committed