Skip to content

Fix all non-bug lints. Switch to let statements. #56956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 124 commits into from
Closed

Fix all non-bug lints. Switch to let statements. #56956

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
9691ad0
Fix all non-bug lints
JohnHeitmann Dec 28, 2018
2878ab8
Use let instead of var, except for globals.
JohnHeitmann Dec 18, 2018
8c304d3
Clean up eslint pragma formatting
JohnHeitmann Jan 2, 2019
aa429bd
Use checked_add for adding time in recv_timeout
faern Dec 14, 2018
e1f7cd8
Add documentation about panicking Add<Duration> impls
faern Dec 14, 2018
2f9d3c7
Uninline some debugging code and use unlikely! macro
Zoxc Dec 5, 2018
44ba1e9
Store `Ident` rather than just `Name` in HIR types `Item` and `Foreig…
alexreg Dec 1, 2018
4748dc5
Implemented variants on type aliases in both ctor and pattern position.
alexreg Dec 3, 2018
711af86
Added tests for feature.
alexreg Dec 3, 2018
9fcbf24
Made suggestion diagnostics more consistent for enum variant names, r…
alexreg Dec 3, 2018
4137376
Fixed tests.
alexreg Dec 6, 2018
c85edb8
Fixed more tests.
alexreg Dec 7, 2018
f30d29a
Added chapter to Unstable Book.
alexreg Dec 3, 2018
12b64b6
Fixed issues raised in first review.
alexreg Dec 6, 2018
06b716e
Work-around for shadowing of variant names with assoc const names in …
alexreg Dec 7, 2018
2eeb932
Added tests for enums & enum aliases with various combinations of gen…
alexreg Dec 13, 2018
f370436
Fixed issues raised in review.
alexreg Dec 15, 2018
f74f949
Expanded tests for enum variants with generic args.
alexreg Dec 15, 2018
8b6769c
Removed unnecessary special handling of `VariantCtor` defs in `instan…
alexreg Dec 15, 2018
72d498d
Fixed several ICEs.
alexreg Dec 17, 2018
89a33dd
Added regression test for using generic parameters on modules.
alexreg Dec 18, 2018
f79535b
Fixed handling of unit variants of aliased enums in type NS.
alexreg Dec 18, 2018
8fec007
Fixed type inference for tuple struct variants.
alexreg Dec 20, 2018
0f3f0b8
Fixed ICE when type arguments are specified on `Self` type.
alexreg Dec 20, 2018
66ee7c4
Minor clean-up
alexreg Dec 26, 2018
2445f43
Minor cosmetic changes
alexreg Dec 26, 2018
92e3a35
Changed resolution of enum variants to low priority.
alexreg Dec 26, 2018
21a012a
Point at correct span for arguments in format strings
estebank Dec 27, 2018
936ea70
Add span label to unused string formatting argument
estebank Dec 27, 2018
acb04c1
retrieve ty info from place_ty
csmoe Dec 27, 2018
fa563d5
Fix typo in pin documentation
sgrif Dec 27, 2018
65819ce
Fix span in char documentation
estebank Dec 27, 2018
efd19d5
Update references to closed issue
ids1024 Dec 28, 2018
3751654
resolve: Fix an ICE in import validation
petrochenkov Dec 28, 2018
b4d18a2
Give the crate select chevron room to breathe.
JohnHeitmann Dec 28, 2018
2cb1ece
Removed aligned ZST requirement from docs of read_/write_unaligned.
kennytm Dec 28, 2018
6a3d95e
Update link to rustc guide
linclark Dec 28, 2018
00ef955
Suggest `.as_ref()` when appropriate for `Option` and `Result`
estebank Dec 28, 2018
e3db7ee
Clarify wording of E0512
varkor Dec 21, 2018
9e15f42
Add specific diagnostic for transmuting between equal associated types
varkor Dec 21, 2018
c7e83ba
Fix warning when compiling rustc
varkor Dec 28, 2018
07f6432
remove remaining copyright headers
matthiaskrgr Dec 28, 2018
2c3d194
resolve: Fix another ICE in import validation
petrochenkov Dec 28, 2018
42730aa
resolve: Never override real bindings with `Def::Err`s from error rec…
petrochenkov Dec 28, 2018
7848878
Update cargo, rls, miri
ehuss Dec 17, 2018
2b7ff35
add non-copy note to stderr
csmoe Dec 27, 2018
9b9fd03
Fixed stderr files for ui tests.
alexreg Dec 29, 2018
c1bea3b
update tests line numbers
matthiaskrgr Dec 29, 2018
643e4e6
resolve: Simplify treatment of ambiguity errors
petrochenkov Dec 29, 2018
f5f5d4c
Use `same_type` instead of duplicating logic
estebank Dec 29, 2018
87a4d21
Remove mention of required memory to build
nagisa Dec 29, 2018
111bcb1
Improve error recovery for some built-in macros
petrochenkov Dec 29, 2018
a5b93f0
Make std::cmp::Ord documentation specify what it means to agree with …
czipperz Dec 29, 2018
6090b31
Specify criterion for PartialOrd
czipperz Dec 30, 2018
faaae93
Mention ToString in std::fmt docs
czipperz Dec 29, 2018
c22ee1a
Do not complain about missing crate named as a keyword
estebank Dec 30, 2018
cceb1f7
Refactor `UserTypeAnnotation`.
davidtwco Nov 16, 2018
43538cb
Always check well-formedness.
davidtwco Nov 22, 2018
7fc1fee
Add test for unreachable well-formedness.
davidtwco Nov 23, 2018
1681b2d
Type annotations in associated constant patterns.
davidtwco Nov 24, 2018
70ffd8d
Add user type annotations to MIR dump.
davidtwco Nov 25, 2018
5e75340
Support user type annotations in `ref` bindings.
davidtwco Nov 25, 2018
3507013
Add explicit error annotations to test.
davidtwco Dec 7, 2018
ae43eec
Fix unresolved inference variable ICE.
davidtwco Dec 9, 2018
ac18fbb
Stop well-formedness checking unreachable code.
davidtwco Dec 18, 2018
ab2a785
Stop duplicating projections of type annotation.
davidtwco Dec 19, 2018
5d760c0
Guarantee `rustc_dump_user_substs` error order.
davidtwco Dec 22, 2018
2a7cc8e
submodules: update clippy from f7bdf500 to 39bd8449
matthiaskrgr Dec 30, 2018
0012941
Add `-Z instrument-mcount`
quark-zju Dec 30, 2018
5345ae9
Address review comments: Remove new `PathResult` variant
estebank Dec 30, 2018
9f0925d
Fix variable string size problem in transmute test
varkor Dec 30, 2018
1ea7f96
Group dep node data into a single structure
Zoxc Dec 22, 2018
c5cba54
Use `entry` API to avoid double lookup when interning dep nodes
Zoxc Dec 23, 2018
216e8cc
Address comments
Zoxc Dec 31, 2018
21e0948
Fix inconsistent Clone documentation.
doitian Dec 26, 2018
7e454d2
Suggest using raw identifiers in 2018 edition when using keywords
estebank Dec 30, 2018
9ee58ff
Address review comments
estebank Dec 30, 2018
fdedfc0
Update tests after rebase
estebank Dec 31, 2018
7cf4468
Account for `\xFF` and `\u{FF}` sequences in string format errors
estebank Dec 27, 2018
73ba9d8
Use structured suggestion for braceless unicode escape squence
estebank Dec 27, 2018
0ed7ced
use structured suggestions for nonexistent fields
euclio Dec 20, 2018
4b57fea
Do not use unicode character in diagnostic help
estebank Dec 31, 2018
3d0bcd2
privacy: Use common `DefId` visiting infra for all privacy visitors
petrochenkov Dec 16, 2018
e4bab0e
Address review comments
petrochenkov Dec 31, 2018
303e440
Bound sgx target_env with fortanix as target_vendor
dingelish Dec 31, 2018
df9f594
Improve type mismatch error messages
codeworm96 Jan 1, 2019
98d4589
Remove min_const_unsafe_fn since it is stable
dingelish Jan 1, 2019
b25abf1
syntax: Fix regression in diagnostics for patterns in trait method pa…
petrochenkov Jan 1, 2019
454f7cb
generate invalidations from 2-phase-borrow activations
nikomatsakis Dec 4, 2018
4bb9ecd
adopt polonius-engine 0.6.2
nikomatsakis Jan 2, 2019
ce6192c
Wf-check the output type of a function in MIR-typeck
matthewjasper Jan 2, 2019
9c9411a
Add missing 'static bound for the Machine trait
matthewjasper Jan 2, 2019
db29f09
remove `commit_if_ok` wrapper
nikomatsakis Oct 15, 2018
a7ec107
remove wrapper functions that had no purpose
nikomatsakis Oct 15, 2018
89ad572
make evaluation track whether outlives relationships mattered
nikomatsakis Sep 20, 2018
1e89f28
introduce ability to detect region constraints from snapshot
nikomatsakis Oct 16, 2018
9e8fa85
select.rs: unsizing coercion should use a subtype
nikomatsakis Dec 27, 2018
254d1a4
WIP: wfcheck ability to detect
nikomatsakis Dec 27, 2018
b46812b
universe transition
nikomatsakis Sep 8, 2018
8165541
add tests exercising `exists<'a> { forall<'b> { .. } }` pattern
nikomatsakis Oct 30, 2018
1423a67
tests: move coherence-subtyping from run-pass to compile-fail
nikomatsakis Oct 30, 2018
c1cd912
tests: worse diagnostics, but basically same errors
nikomatsakis Oct 30, 2018
a0ccf99
tests: cases where we now do the right thing but did not before
nikomatsakis Dec 31, 2018
581dc66
WIP other test changes
nikomatsakis Dec 31, 2018
616898f
remove outdated `rustc_driver` tests
nikomatsakis Oct 31, 2018
94123f2
make `get_highlight_region_for_regionvid` only affect re-vid
nikomatsakis Nov 17, 2018
d354e85
dump out the exact state in error reporting debugs
nikomatsakis Nov 17, 2018
b412851
generalize region highlights into a struct
nikomatsakis Nov 17, 2018
749b6fb
add the ability to highlight placeholders
nikomatsakis Nov 17, 2018
b53e7e3
introduce placeholder-placeholder errors for trait matching
nikomatsakis Nov 17, 2018
d3a8d6d
apply the new placeholder errors even with just one placeholder
nikomatsakis Nov 18, 2018
3744f87
refactor highlighting to take any RegionKind, making it more general
nikomatsakis Nov 18, 2018
deb0366
apply the same logic to ConcreteFailure errors
nikomatsakis Nov 19, 2018
d4fb139
say "the lifetime" instead of "some lifetime" when it feels right
nikomatsakis Nov 19, 2018
e9ba964
improve handling for subtype
nikomatsakis Nov 19, 2018
6d6f12e
pacify the mercilous tidy
nikomatsakis Nov 19, 2018
57f76be
address tmandry nits
nikomatsakis Nov 19, 2018
a90bd6c
add some comments about lifetimes etc
nikomatsakis Nov 19, 2018
500c093
pacify the mercilous eddyb ;)
nikomatsakis Nov 19, 2018
0c81a2f
track if any region constraints involved placeholders
nikomatsakis Nov 20, 2018
f17caab
try to detect affected code and direct people to #56105
nikomatsakis Nov 20, 2018
96640ad
rename `type_moves_by_default` to `type_is_copy_modulo_regions`
nikomatsakis Nov 20, 2018
0303de6
Add optional eslint to the rustdoc-js test target
JohnHeitmann Jan 5, 2019
1c029f4
Delete buggy code that is probably dead
JohnHeitmann Jan 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/librustdoc/html/static/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = {
"extends": "eslint:recommended",
"parserOptions": {
"ecmaVersion": 2015,
"sourceType": "module"
"sourceType": "script"
},
"rules": {
"linebreak-style": [
Expand All @@ -16,6 +16,10 @@ module.exports = {
"semi": [
"error",
"always"
],
"no-constant-condition": [
"error",
{ "checkLoops": false }
]
}
};
Loading