Skip to content

Don't ignore rustdoc when generating comparison summaries #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 17, 2021

Fixes #980.

@rylev
Copy link
Member

rylev commented Sep 17, 2021

This looks good to me, but I'd like @Mark-Simulacrum's perspective on why doc test cases were filtered out in the first place (as that decision predates my involvement in the project).

@Mark-Simulacrum Mark-Simulacrum changed the title Don't ignore rustdoc when generating coverage summaries Don't ignore rustdoc when generating comparison summaries Sep 17, 2021
@Mark-Simulacrum
Copy link
Member

Yeah, this is fine with me as well. I think when we just added the python triage script doc builds were still pretty recently added, and I recall numerous comments from @jyn514 on regressions that they should basically be ignored. I think those reasons no longer hold, though, and based on the perf runs I've seen doc builds don't behave particularly unusually. So I think we can proceed here.

@Mark-Simulacrum Mark-Simulacrum merged commit a6eb310 into rust-lang:master Sep 17, 2021
@jyn514 jyn514 deleted the dont-ignore-rustdoc branch September 17, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf summaries completely ignore rustdoc
3 participants