Skip to content

Update diesel to 2.2.10 #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 25, 2025

Icounts got ~2x slower:
image

time -p CARGO_INCREMENTAL=0 cargo check ; cargo clean
# 5.58 (generated more than 300 warnings!)
# 10.69

time -p CARGO_INCREMENTAL=0 cargo build ; cargo clean
# 5.85
# 11.15

time -p CARGO_INCREMENTAL=0 cargo build --release ; cargo clean
# 6.20
# 11.48

Related issue: #2024

@Kobzol Kobzol added the benchmark-update PR that updates the benchmark set. label Apr 25, 2025
@Kobzol Kobzol requested a review from nnethercote April 25, 2025 08:48
@Kobzol Kobzol mentioned this pull request Apr 25, 2025
40 tasks
@nnethercote
Copy link
Contributor

nnethercote commented Apr 25, 2025

5.58 (generated more than 300 warnings!)

:(

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 25, 2025

5.58 (generated more than 300 warnings!)

:(

Well, it's a good thing, now those warnings will be gone :)

@Kobzol Kobzol merged commit b22333b into rust-lang:master Apr 25, 2025
11 checks passed
@Kobzol Kobzol deleted the benchmark-update-2025-diesel branch April 25, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark-update PR that updates the benchmark set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants