Move rustfmt binariy crates to workspace #4002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
commented
Jan 7, 2020
| @@ -4,3 +4,5 @@ version = "0.1.0" | |||
| authors = ["rustfmt devs <[email protected]>"] | |||
|
|
|||
| [dependencies] | |||
|
|
|||
| [workspace] | |||
There was a problem hiding this comment.
Now that these files are under the workspace, we need to exclude them from the workspace.
topecongiro
commented
Jan 7, 2020
| categories = ["development-tools"] | ||
| edition = "2018" | ||
|
|
||
| [[bin]] | ||
| name = "rustfmt" | ||
| path = "src/bin/main.rs" | ||
| path = "rustfmt-core/rustfmt-bin/src/bin/main.rs" | ||
| test = false |
There was a problem hiding this comment.
Disabled all the tests in the root package as they will be tested in rustfmt-core.
topecongiro
force-pushed
the
add-bin-to-workspace
branch
from
63c7697 to
8ccbacf
Compare
Just the bin names and paths right? |
|
backport not needed |
karyon
added
1x-backport:completed
1x-backport:n/a
and removed
backport-triage
1x-backport:completed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I separated rustfmt into multiple crates, I realized that cargo builds rustfmt-core twice: for rustfmt-core itself and for rustfmt-nightly (the root crate that holds binaries). This duplication is not ideal during development.
The goal of this PR is to mitigate the overhead by moving binaries under the
rustfmt-coreworkspace. The root Cargo.toml works as a shim to the actual binary crate, which is necessary for the rustc repository.The downside is that we now need to keep the root Cargo.toml in sync with rustfmt-core/rustfmt-bin/Cargo.toml.