Skip to content

Remove header license info #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

Remove header license info #1733

merged 1 commit into from
Apr 2, 2019

Conversation

srinivasreddy42
Copy link

@srinivasreddy42 srinivasreddy42 commented Mar 30, 2019 •
edited
Loading

@kinnison
Copy link
Contributor

As I said on the issue, I'm unclear why this is valuable to do.

@nrc
Copy link
Member

nrc commented Apr 1, 2019

I think it is reasonable to do, it brings the script file in line with the rust files (where the license boilerplate was removed along with that in the main Rust repo)

@kinnison kinnison mentioned this pull request Apr 2, 2019
Closed
@kinnison
Copy link
Contributor

kinnison commented Apr 2, 2019

@nrc Fair enough, I'll remove my mild concern then :D

@kinnison kinnison reopened this Apr 2, 2019
kinnison
kinnison approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @nrc's agreement, I withdraw my mild concern.

@kinnison kinnison merged commit f07e26f into rust-lang:master Apr 2, 2019
@srinivasreddy42 srinivasreddy42 deleted the 1732 branch April 3, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srinivasreddy42 @kinnison @nrc @srinivasreddy