Skip to content

feat(toolchain): consider external rust-analyzer when calling a proxy #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented May 7, 2025

Closes #3846.

Following the reasoning in #3846 (comment), this PR make rustup prioritize rustup-hosted RA and only delegates to the outside as a final rescue. This way, it will also close #3299:

> rust-analyzer --version
info: `rust-analyzer` is unavailable for the active toolchain
info: falling back to "~/.local/share/nvim/mason/bin/rust-analyzer"
rust-analyzer 0.3.2449-standalone (3b57c00151 2025-05-04)

This approach has also been approved by @davidbarsky in #t-rustup > More frequent rust-analyzer updates in rustup @ 💬 as a temporary measure before the new update cadence for RA on our release server is settled.

Concerns

  • Should we emit a log line indicating the fallback is happening? Idem for the pre-existing cargo fallback. Added.

@rami3l rami3l force-pushed the feat/smarter-ra-shim branch from 6fa6a79 to 9fd24ff Compare May 8, 2025 10:36
@rami3l rami3l marked this pull request as ready for review May 8, 2025 11:44
@rami3l rami3l requested review from djc and ChrisDenton May 8, 2025 11:44
@rami3l rami3l force-pushed the feat/smarter-ra-shim branch 4 times, most recently from 19cc68b to 15569c1 Compare May 8, 2025 11:53
@rami3l rami3l force-pushed the feat/smarter-ra-shim branch from 15569c1 to a45dd3f Compare May 8, 2025 12:21
@rami3l rami3l force-pushed the feat/smarter-ra-shim branch from a45dd3f to a3330ad Compare May 8, 2025 15:47
@rami3l rami3l force-pushed the feat/smarter-ra-shim branch from 542b5bf to 389474d Compare May 9, 2025 10:39
@rami3l rami3l requested a review from djc May 9, 2025 10:41
@djc djc added this pull request to the merge queue May 9, 2025
Merged via the queue into rust-lang:master with commit 08e36fb May 9, 2025
29 checks passed
@rami3l rami3l deleted the feat/smarter-ra-shim branch May 10, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants