Backfill all currently listed alumni's teams #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
commented
Dec 1, 2023
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
| @@ -24,6 +24,7 @@ alumni = [ | |||
| "mcarton", | |||
| "phansch", | |||
| "camsteffen", | |||
| "birkenfeld", | |||
rylev
approved these changes
Dec 4, 2023
| "valgrimm", | ||
| "whitequark", | ||
| ] | ||
| members = [] | ||
| # Temporary key that includes all members listed as alumni in the individual |
There was a problem hiding this comment.
I guess this key is not really temporary as we still want an alumni team that includes all other teams' alumni. Perhaps we should remove this comment?
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the code from #1125 to extract former team membership from commit history.
This PR fills in team membership for all contributors currently listed in the deprecated alumni.toml, per Ryan's recommendation in #1126 (review) to bring back deleted teams in archived form.
The new archived teams added in this PR need to be filled in with other former members beyond this, but I will handle that separately. For now this PR is enough to bring the deprecated alumni team down to 0 members, and begin removing code related to it.
The only change to the website will be for birkenfeld, who will begin to appear under Clippy alumni at https://www.rust-lang.org/governance/teams/dev-tools#clippy. The other teams are archived teams, which do not get reflected on the website. All archived team members and birkenfeld will continue to appear in the overall alumni list at https://www.rust-lang.org/governance/teams/alumni.