Skip to content

fix: Chinese translation of homepage.ftl & common.ftl #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Integral-Tech
Copy link

No description provided.

@Integral-Tech Integral-Tech requested a review from a team as a code owner December 24, 2024 08:24
@Integral-Tech Integral-Tech changed the title fix: Chinese translation of homepage.ftl fix: Chinese translation of homepage.ftl & common.ftl Dec 24, 2024
@senekor senekor added the A-i18n Internationalising the website. label Dec 24, 2024
@senekor
Copy link
Contributor

senekor commented Dec 24, 2024

Translation improvements are on hold as explained at the top of the readme. The PR can stay open in case the situation changes in the future.

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either translation is correct. I think you should make it clear why this is needed in the PR description.

(Granted, the tagline and meta description after this change are more close to translations of zh-TW, and I was one of the reviewers of zh-TW)

@Manishearth Manishearth closed this Mar 2, 2025
@Integral-Tech
Copy link
Author

Integral-Tech commented Mar 2, 2025

@weihanglo IMO although the original translation is grammatically correct, it is too verbose.

一门赋予每个人构建可靠且高效软件能力的语言

@Integral-Tech
Copy link
Author

Integral-Tech commented Mar 2, 2025

@Manishearth Could you please reopen my pull request?

@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2025

"correct but a bit verbose" is generally within parameters for this website. when we have a proper translation team again we can defer to them on matters of style.

I'd leave it open if it were a matter of correctness, but if it isn't I'd rather not leave it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-i18n Internationalising the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants