Skip to content

Migrate CI to GitHub Actions #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2020
Merged

Migrate CI to GitHub Actions #180

merged 2 commits into from
Dec 14, 2020

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Dec 14, 2020 •
edited
Loading

Closes #174

Converts most existing tests except related to WASM targets.

@josephlr
Copy link
Member

@newpavlov Do you know why AppVeyor Is still running? Is there some way to turn it off?

@newpavlov
Copy link
Member Author

I am not sure. Probably because we still have its config in the master branch. Hopefully it will be solved after merge.

@dhardy
Copy link
Member

dhardy commented Dec 14, 2020

Yup, I can turn it off: (1) there's a webhook still registered and (2) AppVeyor was set up through my account. I'll clear it for you.

@newpavlov newpavlov requested a review from josephlr December 14, 2020 20:50
josephlr
josephlr approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I just have a few nits/questions

.github/workflows/tests.yml
with:
profile: minimal
target: ${{ matrix.target }}
toolchain: nightly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using the stable toolchain for these targets?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis config was using nightly, so I haven't changed it. I can try stable instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, I think it's worth to keep it nightly to allow early compiler bug detection if there will be any affecting us. I also will enable the cron job option to run CI periodically.

@newpavlov newpavlov merged commit 6f11660 into master Dec 14, 2020
@newpavlov newpavlov deleted the ga_ci branch December 14, 2020 21:50
@newpavlov newpavlov mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions?
3 participants
@newpavlov @josephlr @dhardy