Skip to content

fix: Override other implementations on custom feature #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Override other implementations on custom feature #501

wants to merge 1 commit into from

Conversation

VisualEhrmanntraut
Copy link

Fixes #500

@newpavlov
Copy link
Member

newpavlov commented Sep 23, 2024

We intentionally do not allow to overwrite "default" entropy sources with custom ones. This may change with #498, but your current approach certainly is a no-go.

@VisualEhrmanntraut
Copy link
Author

VisualEhrmanntraut commented Sep 24, 2024

@newpavlov How about I instead make a feature named prefer-custom or use-custom which will make it prefer the custom implementation to the built-in ones?

@newpavlov
Copy link
Member

newpavlov commented Sep 24, 2024

Renaming the feature does not solve the root security issue with overriding default entropy sources. As I wrote in the issue, at the moment, your best option is to simply patch the getrandom crate with your custom version or introducing a proper custom target for your experiments.

@newpavlov newpavlov closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for targeting the macOS (Darwin/XNU) kernel
2 participants