Compute super-k-mer positions as u32s, add wrappers and tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RagnarGrootKoerkamp
approved these changes
Feb 1, 2025
| v | ||
| } | ||
|
|
||
| /// Convenience wrapper around `collect_and_dedup_with_index_into`. |
There was a problem hiding this comment.
document which output component contains what (here and possibly elsewhere)
| @@ -162,7 +162,7 @@ pub mod private { | |||
| /// Re-export of the `packed-seq` crate. | |||
| pub use packed_seq; | |||
|
|
|||
There was a problem hiding this comment.
Add a little ## Super-k-mers paragraph at line 42 above maybe?
And then also a quick hand-made example showing some explicit numbers.
RagnarGrootKoerkamp
force-pushed
the
superkmers
branch
from
883aad8 to
6522b32
Compare
|
@imartayan was there anything holding this up? Could you fix the remaining items? |
|
Sorry, I've been quite busy lately and kept postponing this. I'll try to do it by tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.