Converting to mdbook #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix title typo Add missing posts to the directory
simonsan
added
C-addition
simonsan
reviewed
Jan 1, 2021
There was a problem hiding this comment.
I tested it and I assume this PR might be outdated due to feature additions to mdbook. I added a book.toml in #111 and it basically does the same without any changes to the repository structure (besides the additions of a Readme.md file for each subfolder/subcategory). So imho we could close this and continue work in #111 @marcoieni , your thoughts?
simonsan
added
the
C-outdated
|
I close this in favor of #111 since I think that a lot of the work done for this PR is not required anymore with newer versions of mdbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue#6, this PR tries to add rendering and testing support for the project with mdbook.
To maintain the current structure of the project while playing nicely with mdbook's building system, a dirty script was added into the project. Currently, just type
cargo run renderin the shell, the rendered pages would be ready for publishing in a subdirectory calledbook/. Check it out on gh-pages.Currently two problems remains:
cargo run testwould fail,Hopefully both problems would be gone after their related PRs being merged into master.
Related: #51 #43