Implement Mii Selector applet #78

Techie-Pi · 2022-10-20T20:20:51Z

I've implemented the Mii Selector applet, I have yet to add documentation, but I would like to see your opinions on the API.
Specially around the creation and usage of the enums MiiConfigIndex and MiiType.

Techie-Pi · 2022-10-20T21:22:36Z

Also, out of curiosity, why is MiiData an opaque type?
Nevermind, just saw the issue, that's actually sad tbh

Techie-Pi · 2022-10-21T07:15:09Z

I've been researching, and the representation of the MiiData given by the 3DS doesn't change at all and is documented. The purpose of libctru's MiiData is to imitate the representation so that the struct is generated directly from the 3DS' MiiData.

Instead of that, we could parse the raw data to a Rust-compatible struct. I'll do some testing

Techie-Pi · 2022-10-21T11:58:02Z

Looks like it is possible, and quite simple tbh, maybe I could also add this to the PR.
Edit: Done... that was easier than what I had thought... I'll clean-up the code, fix a few things, and I'll incorporate the code into the PR

ctru-rs/src/mii.rs

ctru-rs/examples/mii-selector.rs

ctru-rs/src/applets/mii_selector.rs

ctru-rs/src/mii.rs

ctru-rs/examples/mii-selector.rs

ctru-rs/src/applets/mii_selector.rs

ctru-rs/src/mii.rs

Techie-Pi · 2022-10-24T12:16:04Z

(For some reason I can't request multiple reviews at the same time /shrug)

ctru-rs/src/applets/mii_selector.rs

ctru-rs/src/mii.rs

ctru-rs/src/applets/mii_selector.rs

- Make ``MiiSelectorReturn`` ``non_exhaustive`` - Remove ``checksum`` from ``MiiSelectorReturn`` - Change ``From`` impl for ``MiiSelectorReturn`` - Rename ``OriginConsole`` members - Fix ranges

Apply nightly lints I updated my toolchain to 1.66-nightly to fix all the files

Techie-Pi · 2022-10-27T19:13:59Z

I've squashed some commits (mostly docs and cargo fmt/clippy)

Meziu

Looks good to me!

ctru-rs/src/applets/mii_selector.rs

ctru-rs/src/mii.rs

ian-h-chamberlain

Sorry I meant to review this a while ago, but finally got a chance to take a look and it seems pretty cool!

Some of ctru::MiiData might be worth documenting further, if we're going to maintain a totally separate struct vs the ctru_sys::MiiData, but I think this is good to start. There's lots of documentation stuff that needs to be done across the board so I don't think it should keep this from merging as-is.

Techie-Pi · 2022-11-03T21:25:06Z

After current concerns about this PR are resolved, I plan on adding (at least) some basic documentation (and maybe references to the 3dbrew wiki) before merging, though I think the best thing would be to merge this PR with basic documentation and add more detailed documentation in a follow-up PR (I'm not a native English speaker, so I may need help in the follow-up PR, which may take some time to make because of that :p)

Techie-Pi · 2022-11-09T09:26:24Z

Is there anything that should be documented in this PR instead of the follow-up? Or is this ready to merge?

Meziu · 2022-11-09T10:44:21Z

Is there anything that should be documented in this PR instead of the follow-up? Or is this ready to merge?

I believe it’s fine for now. PR anything you want to add.

Techie-Pi added 4 commits October 20, 2022 21:28

Initial mii selector implementation

32db2c6

Fix bug with author and impl From for MiiConfigIndex

b33411f

Add mii_selector example

4b43561

Cargo fmt

de51d97

Techie-Pi added 5 commits October 21, 2022 19:59

Implement MiiData parsing

3c9bd8f

Rename Mii Selector example

e6cc659

Add MiiData example

19ebd49

Clippy

0a6654a

Remove comment

1dbb576

Meziu reviewed Oct 23, 2022

View reviewed changes

ctru-rs/src/mii.rs Outdated Show resolved Hide resolved

Meziu reviewed Oct 23, 2022

View reviewed changes

ctru-rs/src/mii.rs Outdated Show resolved Hide resolved

Meziu reviewed Oct 23, 2022

View reviewed changes

ctru-rs/src/mii.rs Outdated Show resolved Hide resolved

Meziu reviewed Oct 23, 2022

View reviewed changes

ctru-rs/examples/mii-selector.rs Show resolved Hide resolved

Meziu reviewed Oct 23, 2022

View reviewed changes

ctru-rs/examples/mii-selector.rs Outdated Show resolved Hide resolved

Meziu requested changes Oct 23, 2022

View reviewed changes

AzureMarker reviewed Oct 23, 2022

View reviewed changes

Techie-Pi requested review from Meziu and AzureMarker and removed request for Meziu and AzureMarker October 24, 2022 01:05

Meziu requested a review from AzureMarker October 24, 2022 12:20

AzureMarker reviewed Oct 26, 2022

View reviewed changes

ctru-rs/src/applets/mii_selector.rs Outdated Show resolved Hide resolved

ctru-rs/src/applets/mii_selector.rs Outdated Show resolved Hide resolved

ctru-rs/src/mii.rs Outdated Show resolved Hide resolved

ctru-rs/src/mii.rs Outdated Show resolved Hide resolved

Meziu requested changes Oct 26, 2022

View reviewed changes

ctru-rs/src/applets/mii_selector.rs Show resolved Hide resolved

Techie-Pi requested review from AzureMarker and Meziu October 26, 2022 18:37

Techie-Pi added 16 commits October 27, 2022 21:12

Cargo fmt & clippy

4b99e92

Apply suggestions

1d92f0f

Fix Mii Selector example

fe0d03c

Fix RegionLock::None refactor

be87134

Apply some suggestions

7ca152a

Improve mii-selector example and a few fixes

a9569b5

Clippy & cargo fmt

d7a6843

Fix issue related to endianness and improve wording

dd5b9f7

Add docs

91f65a0

Document values sometimes not being straight forward

441ab93

Cargo fmt

f8baff0

Document set_title input and NUL bytes

1310507

Fix rustdoc link

4d88ba9

Move some styles inside the their details struct for consistency

7c24404

Address comments

16f8de4

- Make ``MiiSelectorReturn`` ``non_exhaustive`` - Remove ``checksum`` from ``MiiSelectorReturn`` - Change ``From`` impl for ``MiiSelectorReturn`` - Rename ``OriginConsole`` members - Fix ranges

Apply cargo check suggestions

accf99b

Apply nightly lints I updated my toolchain to 1.66-nightly to fix all the files

Meziu approved these changes Oct 31, 2022

View reviewed changes

AzureMarker reviewed Nov 2, 2022

View reviewed changes

ctru-rs/src/applets/mii_selector.rs Outdated Show resolved Hide resolved

ctru-rs/src/mii.rs Show resolved Hide resolved

ctru-rs/src/mii.rs Show resolved Hide resolved

Address comments

01e9c70

Techie-Pi requested a review from AzureMarker November 2, 2022 20:21

ian-h-chamberlain approved these changes Nov 3, 2022

View reviewed changes

AzureMarker approved these changes Nov 9, 2022

View reviewed changes

Rename a few variables and document skipped bits

42345d1

Meziu merged commit 4e22166 into rust3ds:master Nov 9, 2022

Implement Mii Selector applet #78

Implement Mii Selector applet #78

Uh oh!

Conversation

Techie-Pi commented Oct 20, 2022

Uh oh!

Techie-Pi commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Techie-Pi commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Techie-Pi commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Techie-Pi commented Oct 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Techie-Pi commented Oct 27, 2022

Uh oh!

Meziu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ian-h-chamberlain left a comment

Choose a reason for hiding this comment

Uh oh!

Techie-Pi commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Techie-Pi commented Nov 9, 2022

Uh oh!

Meziu commented Nov 9, 2022

Uh oh!

Uh oh!

Techie-Pi commented Oct 20, 2022 •

edited

Loading

Techie-Pi commented Oct 21, 2022 •

edited

Loading

Techie-Pi commented Oct 21, 2022 •

edited

Loading

Techie-Pi commented Nov 3, 2022 •

edited

Loading