-
Notifications
You must be signed in to change notification settings - Fork 8
[Sphinx Extension] Add offline build support #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I’ll rebase once #23 is merged. One more question—could the -o flag cause any confusion? It’s typically used for output, but here it’s being used to represent offline. |
let me fix something before merging |
Hi @x0rw -- is this ready for review? Thanks! |
Hi @PLeVasseur |
I need to push another PR through first which will update the spec lock file (#28). Hope to do that today and will then let you know. |
Hey @PLeVasseur, i noticed some old 'fls.lock' references while grepping, i updated them in the last commit. |
Cool, thanks! By the way -- finally we've merged the style guidelines PR, so let's get yours rebased and merged as well. |
Great, it's rebased on the last commit now, let me know if there is something related to this extension in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @x0rw -- I noticed an update you'll need to make. Can you check?
Hey @x0rw -- could you rebase one more time? Sorry! I realized there was a bug I had to fix in the workflow to trigger on merge queue addition. |
No worries at all — just rebased! I also added docstrings and a build timer to the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this functionality @x0rw! LGTM
This PR adds the --offline flag to ./make.py for offline builds, addressing issue #13.
Resolves #13.