Skip to content

[Sphinx Extension] Add offline build support #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2025

Conversation

x0rw
Copy link
Contributor

@x0rw x0rw commented Mar 21, 2025

This PR adds the --offline flag to ./make.py for offline builds, addressing issue #13.

  • Added support for offline mode during build(--offline).
  • Updated documentation to reflect the change.

Resolves #13.

Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @x0rw -- thanks for the contribution!

I'd like to let #23 go in first, have you rebase, and then we can try to merge this.

@x0rw
Copy link
Contributor Author

x0rw commented Mar 28, 2025

Thanks for the feedback! I’ll rebase once #23 is merged. One more question—could the -o flag cause any confusion? It’s typically used for output, but here it’s being used to represent offline.

@PLeVasseur
Copy link
Collaborator

FYI @x0rw -- #23 is merged, so you can rebase this.

@x0rw
Copy link
Contributor Author

x0rw commented Mar 29, 2025

let me fix something before merging

@PLeVasseur
Copy link
Collaborator

Hi @x0rw -- is this ready for review? Thanks!

@x0rw
Copy link
Contributor Author

x0rw commented Apr 7, 2025

Hi @PLeVasseur
Yes it is ready for review, let me know if another rebase is needed.

@PLeVasseur
Copy link
Collaborator

PLeVasseur commented Apr 7, 2025

I need to push another PR through first which will update the spec lock file (#28). Hope to do that today and will then let you know.

@x0rw
Copy link
Contributor Author

x0rw commented Apr 7, 2025

I need to push another PR through first which will update the spec lock file (#28). Hope to do that today and will then let you know.

Alright,
Oh yes, i've noticed this issue(#28) when Ferrocene updated their paragraph-ids.json two weeks ago, i wanted to address it after this PR.

@PLeVasseur
Copy link
Collaborator

Hey @x0rw -- #28 is closed, so I think you're safe to rebase now. The offline build is a very handy feature I'd like to add.

@x0rw
Copy link
Contributor Author

x0rw commented Apr 14, 2025

Hey @PLeVasseur, i noticed some old 'fls.lock' references while grepping, i updated them in the last commit.

@PLeVasseur
Copy link
Collaborator

Hey @PLeVasseur, i noticed some old 'fls.lock' references while grepping, i updated them in the last commit.

Cool, thanks!

By the way -- finally we've merged the style guidelines PR, so let's get yours rebased and merged as well.

@x0rw
Copy link
Contributor Author

x0rw commented Apr 19, 2025

Hey @PLeVasseur, i noticed some old 'fls.lock' references while grepping, i updated them in the last commit.

Cool, thanks!

By the way -- finally we've merged the style guidelines PR, so let's get yours rebased and merged as well.

Great, it's rebased on the last commit now, let me know if there is something related to this extension in the future.

Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @x0rw -- I noticed an update you'll need to make. Can you check?

@PLeVasseur
Copy link
Collaborator

Hey @x0rw -- could you rebase one more time? Sorry! I realized there was a bug I had to fix in the workflow to trigger on merge queue addition.

@x0rw
Copy link
Contributor Author

x0rw commented Apr 21, 2025

Hey @x0rw -- could you rebase one more time? Sorry! I realized there was a bug I had to fix in the workflow to trigger on merge queue addition.

No worries at all — just rebased! I also added docstrings and a build timer to the script.

Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this functionality @x0rw! LGTM

@PLeVasseur PLeVasseur added this pull request to the merge queue Apr 21, 2025
Merged via the queue into rustfoundation:main with commit bf33bea Apr 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make buildable without internet connection
2 participants