Skip to content

Simplified webgl example #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

Simplified webgl example #1336

merged 1 commit into from
Mar 11, 2019

Conversation

ibaryshnikov
Copy link
Member

Removed <'a, T: IntoIterator<Item = &'a WebGlShader>> from link_program sigrature, used String::from instead of into for consistency

Closes #1322

chinedufn
chinedufn approved these changes Mar 10, 2019
View reviewed changes
Copy link
Contributor

@chinedufn chinedufn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

fitzgen
fitzgen approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ibaryshnikov :)

@fitzgen fitzgen merged commit c857a93 into rustwasm:master Mar 11, 2019
@ibaryshnikov ibaryshnikov deleted the issue-1322-simplify-webgl-example branch April 2, 2019 21:23
@tiye
Copy link

tiye commented May 13, 2022

looks broken now https://rustwasm.github.io/wasm-bindgen/exbuild/webgl/ am I alone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@chinedufn chinedufn chinedufn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibaryshnikov @tiye @fitzgen @chinedufn