-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for version specifications #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ashleygwilliams ok I've updated with our discussion this morning:
|
The example should use Unlike Rust, npm does not default to semver (the string So if you want to use semver semantics you need to add a |
@Pauan ah indeed! That'll happen automatically here, but I can update example usage of this to recommend that. Currently wasm-bindgen doesn't interpret these strings at all, it just ferries them along |
@alexcrichton @Pauan it's defnitely an interesting question what type of "semver defaults" we want to enforce given that npm and cargo have different ones. seems like a decision for |
This commit adds a `#[wasm_bindgen(version = "...")]` attribute support. This information is eventually written into a `__wasm_pack_unstable` section. Currently this is a strawman for the proposal in ashleygwilliams/wasm-pack#101
Ok sounds good! I think this is ready to go so I'm going to merge. |
First added in rustwasm#161 this never ended up panning out, so let's remove the experimental suport which isn't actually used by anything today and hold off on any other changes until an RFC happens.
First added in rustwasm#161 this never ended up panning out, so let's remove the experimental suport which isn't actually used by anything today and hold off on any other changes until an RFC happens.
First added in #161 this never ended up panning out, so let's remove the experimental suport which isn't actually used by anything today and hold off on any other changes until an RFC happens.
This commit adds a
#[wasm_bindgen(version = "...")]
attribute support. Thisinformation is eventually written into a
__wasm_pack_unstable
section.Currently this is a strawman for the proposal in ashleygwilliams/wasm-pack#101