Enable cargo test where possible
#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @fitzgen, I'm curious what you think of this approach. The tl;dr; is that wasm-bindgen should be fine to mix in with cross-platform code, but if you invoke any imported functionality (aka anything that would otherwise call out to JS) then it panics at runtime. |
Currently `#[wasm_bindgen]` generates a bunch of references to symbols that don't actually exist on non-wasm targets, making it more difficult to get a crate working across multiple platforms. This commit updates the symbol references to be dummy ones that panic on non-wasm targets to allow simple testing/benchmarking to work on native targets. While this isn't a perfect solution for #114 it's probably as good as we can do for now pending upstream Cargo features, so I'm gonna say that it... Closes #114
fitzgen
reviewed
Apr 30, 2018
|
@fitzgen I think you'll still need to do something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
#[wasm_bindgen]generates a bunch of references to symbols thatdon't actually exist on non-wasm targets, making it more difficult to get a
crate working across multiple platforms. This commit updates the symbol
references to be dummy ones that panic on non-wasm targets to allow simple
testing/benchmarking to work on native targets.
While this isn't a perfect solution for #114 it's probably as good as we can do
for now pending upstream Cargo features, so I'm gonna say that it...
Closes #114