Load dependencies from wasm-bindgen
#116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
reviewed
Apr 27, 2018
src/manifest.rs
Outdated
| }, | ||
| } | ||
|
|
||
| println!("{:?}", wasm); |
There was a problem hiding this comment.
Was this for debugging purposes?
|
lol haha i was gonna implement this, but i guess i don't have to anymore, will review later today. |
This commit updates `wasm-pack` to read the `__wasm_pack_unstable` section of wasm binaries that it exeutes over. This section is then parsed and NPM dependencies are extracted, if any, and inserted into the generated `package.json`. Closes rustwasm#101
|
blocked pending RFC on npm deps expression |
|
i'm going to close this because it is very stale and we've decided that this is not how we want to load npm deps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
wasm-packto read the__wasm_pack_unstablesection ofwasm binaries that it exeutes over. This section is then parsed and NPM
dependencies are extracted, if any, and inserted into the generated
package.json.Closes #101