Skip to content

Throw bespoke error when mainnet fork isn't Ethereum Mainnet #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaulRBerg opened this issue Apr 23, 2025 · 2 comments · Fixed by #6
Closed

Throw bespoke error when mainnet fork isn't Ethereum Mainnet #3

PaulRBerg opened this issue Apr 23, 2025 · 2 comments · Fixed by #6
Assignees
@PaulRBerg
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

I just spent 15 minutes debugging an annoying EvmError that was due to my mainnet RPC URL pointing to a non-Ethereum Mainnet chain.

This is really Foundry's fault, but until they add better reporting, we can explicitly load the chain ID and check if the ID matches the expected value (1).
@PaulRBerg PaulRBerg added effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Apr 23, 2025
@PaulRBerg PaulRBerg self-assigned this Apr 23, 2025
@PaulRBerg PaulRBerg mentioned this issue Apr 23, 2025
Closed
PaulRBerg added a commit that referenced this issue Apr 23, 2025
@PaulRBerg
refactor: throw error when chainId != 1
961d517 
Closes #3
@PaulRBerg PaulRBerg mentioned this issue Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major refactor sablier-labs/benchmarks
1 participant
@PaulRBerg