Major refactor #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: use bun text lockfile chore: delete unused remappings file chore: polish ignore files chore: prose wrap only for md files chore: remove default prettier settings chore: update vscode settings chore: various polishes
chore: fix env var name test: add links to docs
feat: script for formatting numbers fix: fix stream ids refactor: improve logical structure of "scripts" in "package.json refactor: better names for variable refactor: kebab-case for Markdown files refactor: rename to "instrument_" refactor: various improvements closes #5
smol-ninja
requested changes
Apr 23, 2025
refactor: no comma for 4 digit numbers refactor: better organization refactor: cleaner markdown content writing refactor: rename to RESULTS_FILE
|
Ready for re-review @smol-ninja |
smol-ninja
requested changes
Apr 24, 2025
smol-ninja
reviewed
Apr 24, 2025
|
@smol-ninja can you please implement all feedback yourself? |
|
@PaulRBerg I will implement those refactors myself so please dont push any commit to this PR until I do that to avoid conflicts. |
|
yessir |
smol-ninja
approved these changes
Apr 25, 2025
|
@PaulRBerg you can now have a look at the diff and merge the PR if you are happy with the new changes. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog