WIP: LLVM 14.0.6 #1

rubdos · 2022-06-24T13:17:01Z

LLVM 12+ is necessary for Rust 1.55+ sailfishos/rust#15

Nothing has been tested yet here. Just putting out the code. This one was easy to get to compile.

TODO:

Compile Rust with it (trying this out as we speak)
Fix aarch64 build (libz.so is getting searched for in /usr/lib instead of /usr/lib64).
Check whether Clang should also get bumped

rubdos · 2022-06-24T18:16:07Z

So, this compiles under armv7hl and i486, but fails under aarch64 with a reference to libz.so

CMake Warning:
  Manually-specified variables were not used by the project:

    LIB_INSTALL_DIR


-- Build files have been written to: /home/rsmet/src/sailfishos-rust/llvm/llvm/llvm/build
+ /usr/bin/ninja -v -j24
ninja: error: '/usr/lib/libz.so', needed by 'bin/llvm-tblgen', missing and no known rule to make it
error: Bad exit status from /var/tmp/rpm-tmp.kncB55 (%build)

I suppose I'll need to teach llvm to find this under /usr/lib64/libz.so, somehow.

Thaodan · 2022-06-24T18:20:38Z

CMake Warning:
Manually-specified variables were not used by the project:
LIB_INSTALL_DIR

You can ignore that, it comes from the %cmake macro.

Thaodan · 2022-06-24T23:03:28Z

CMake Warning:
Manually-specified variables were not used by the project:
LIB_INSTALL_DIR

You can ignore that, it comes from the %cmake macro.

So, this compiles under armv7hl and i486, but fails under aarch64 with a reference to libz.so
CMake Warning:
  Manually-specified variables were not used by the project:

    LIB_INSTALL_DIR


-- Build files have been written to: /home/rsmet/src/sailfishos-rust/llvm/llvm/llvm/build
+ /usr/bin/ninja -v -j24
ninja: error: '/usr/lib/libz.so', needed by 'bin/llvm-tblgen', missing and no known rule to make it
error: Bad exit status from /var/tmp/rpm-tmp.kncB55 (%build)
I suppose I'll need to teach llvm to find this under /usr/lib64/libz.so, somehow.

Can you check the ninja file, is libdir set correctly?

rubdos · 2022-06-25T07:19:17Z

Can you check the ninja file, is libdir set correctly?

It was indeed badly generated.

Starting from a clean build directory, aarch64 just compiles fine. Reason was a dirty build directory from the i486/armv7hl compilation.

What's my best next step here; submit the packages to OBS and those as a repo to do my testing against? Manually installing all these RPMs in my targets is quite exhausting. I don't think I currently have an OBS account.

Thaodan · 2022-06-25T22:44:29Z

What's my best next step here; submit the packages to OBS and those as a repo to do my testing against? Manually installing all these RPMs in my

Yes please do so. I can take the internal testing next week, over all this is good work.

rubdos · 2022-06-26T09:20:53Z

I'm still trying to tackle an issue with Aarch64. By default, LLVM now emits LSE/out-of-line atomic calls, but these are not supported in GCC < 9.3.1.

I'm testing a patch that disables out-of-line atomics on MeeGo vendors now.

FWIW, I'm adding LLVM 14 and Rust 1.61 on my personal home-hosted repo for tests; I've scripted a bit around it.

I hope you don't mind me re-organising the patch files a bit for easier rebases in the future.

rubdos · 2022-06-26T09:29:11Z

rpm/0004-Make-funwind-tables-the-default-for-all-archs.patch

-  return getArch() == llvm::Triple::x86_64;
-+  return true;
- }
-
- bool Generic_GCC::isPICDefault() const {
-- 
-2.20.1
-
+  if (getTriple().isMeeGo()) {
+    return true;
+  }
+   switch (getArch()) {
+   case llvm::Triple::aarch64:
+   case llvm::Triple::ppc:


This was the most interesting conflict of the rebase. I'm not sure whether this still takes the commit message to heart .This might need some change in either the commit message or in the code (to replace it again with return true;)

rubdos · 2022-06-27T08:44:56Z

I'm testing a patch that disables out-of-line atomics on MeeGo vendors now.

I just tested the 0006 patch, and it doesn't help. The resulting log of installing this version and trying to compile sccache can be found here: https://gitlab.com/whisperfish/sailo-rs/-/jobs/2642920507/raw

Could it be that Rust calls LLVM with just aarch64-linux-gnu instead of aarch64-linux-meego? Would make sense if it does, but that also means I cannot really disable it only for MeeGo targets. I'll try disabling out-of-line altogether next.

thigg · 2022-06-27T11:48:34Z

I have no idea what I am doing, but just wanted to leave this here, in case you were searching for it:

Options -moutline-atomics and -mno-outline-atomics to enable and disable it
were added to clang driver.

source

rubdos · 2022-06-28T07:15:49Z

I have no idea what I am doing, but just wanted to leave this here, in case you were searching for it:

Options -moutline-atomics and -mno-outline-atomics to enable and disable it
were added to clang driver.

source

Found these indeed, but at no point are we using clang. The equivalent would be -C target-feature=-outline-atomics, but that doesn't pass through for some reason. Worst case, I'll have to summon a real Rustacean to the discussion.

Thaodan · 2022-10-11T07:55:10Z

What's my best next step here; submit the packages to OBS and those as a repo to do my testing against? Manually installing all these RPMs in my

Yes please do so. I can take the internal testing next week, over all this is good work.

rubdos · 2022-10-12T11:48:52Z

Is there any chance someone at Jolla can continue this work? I cannot seem to find a sizable slot in my schedule any time soon to fit the mental power to finish this up. Since it's apparently also needed for sailfishos/mesa#2, I suppose there's an incentive for Jolla to continue this work.

mlehtima · 2022-10-12T11:52:47Z

Is there any chance someone at Jolla can continue this work? I cannot seem to find a sizable slot in my schedule any time soon to fit the mental power to finish this up. Since it's apparently also needed for sailfishos/mesa#2, I suppose there's an incentive for Jolla to continue this work.

Hi, I already did a test build of these and had to fix clang spec to make it build so maybe I can make a new PR or push to your branch.

rubdos · 2022-10-13T07:03:19Z

Hi, I already did a test build of these and had to fix clang spec to make it build so maybe I can make a new PR or push to your branch.

Glad you found a fix for the clang build. I've added you to my fork as collaborator, feel free to push to this branch if that's easy for you! It's very inaptly named llvm-15 :-)

simonschmeisser · 2023-01-21T12:10:32Z

Would it help to package gcc 12 or similar in parallel to the current gcc8? Has anyone started working on it or would I need to start from scratch? If so would you recommend starting from the current huge gcc8 rpm spec or from fedora or similar?

mlehtima · 2023-02-06T17:52:20Z

Closing this as update was done in #2

rubdos changed the title ~~WIP: LLVM 15~~ WIP: LLVM 14.0.5 Jun 24, 2022

LLVM 14.0.5

e594523

rubdos force-pushed the llvm-15 branch from c90fb9a to e594523 Compare June 24, 2022 16:12

rubdos mentioned this pull request Jun 25, 2022

WIP: Rust 1.61 sailfishos/rust#15

Closed

2 tasks

Update LLVM to 14.0.6

6b37b82

rubdos force-pushed the llvm-15 branch from 666f026 to ca88e82 Compare June 26, 2022 09:21

rubdos commented Jun 26, 2022

View reviewed changes

rubdos added 2 commits June 26, 2022 11:31

Add Triple::isMeeGo(), disable out-of-line-atomics for MeeGo

b8635ee

Bump clang version

d875cea

rubdos force-pushed the llvm-15 branch from ca88e82 to d875cea Compare June 26, 2022 09:31

rubdos changed the title ~~WIP: LLVM 14.0.5~~ WIP: LLVM 14.0.6 Jun 27, 2022

mlehtima mentioned this pull request Oct 11, 2022

[mesa] Update to version 21.3.9. JB#58952 sailfishos/mesa#2

Merged

mlehtima mentioned this pull request Jan 30, 2023

[llvm] Update llvm and clang to 14.0.6. JB#58952 #2

Merged

mlehtima closed this Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: LLVM 14.0.6 #1

WIP: LLVM 14.0.6 #1

rubdos commented Jun 24, 2022 •

edited

Loading

rubdos commented Jun 24, 2022

Thaodan commented Jun 24, 2022

Thaodan commented Jun 24, 2022

rubdos commented Jun 25, 2022

Thaodan commented Jun 25, 2022 via email

rubdos commented Jun 26, 2022

rubdos Jun 26, 2022

rubdos commented Jun 27, 2022

thigg commented Jun 27, 2022

rubdos commented Jun 28, 2022

Thaodan commented Oct 11, 2022 via email

rubdos commented Oct 12, 2022

mlehtima commented Oct 12, 2022 •

edited

Loading

rubdos commented Oct 13, 2022

simonschmeisser commented Jan 21, 2023

mlehtima commented Feb 6, 2023

WIP: LLVM 14.0.6 #1

WIP: LLVM 14.0.6 #1

Conversation

rubdos commented Jun 24, 2022 • edited Loading

rubdos commented Jun 24, 2022

Thaodan commented Jun 24, 2022

Thaodan commented Jun 24, 2022

rubdos commented Jun 25, 2022

Thaodan commented Jun 25, 2022 via email

rubdos commented Jun 26, 2022

rubdos Jun 26, 2022

Choose a reason for hiding this comment

rubdos commented Jun 27, 2022

thigg commented Jun 27, 2022

rubdos commented Jun 28, 2022

Thaodan commented Oct 11, 2022 via email

rubdos commented Oct 12, 2022

mlehtima commented Oct 12, 2022 • edited Loading

rubdos commented Oct 13, 2022

simonschmeisser commented Jan 21, 2023

mlehtima commented Feb 6, 2023

rubdos commented Jun 24, 2022 •

edited

Loading

mlehtima commented Oct 12, 2022 •

edited

Loading