fix: Perform the last action with the column name modified. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
tashiro-akira
requested review from
kimusaku and
fukuta-flab
and removed request for
a team
added 2 commits
December 12, 2023 15:50
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
AkiraUra
requested changes
Jan 5, 2024
sapientml_core/generator.py
Outdated
Comment on lines
222
to
248
| pipeline.validation = code_block.validation + pipeline.validation | ||
| pipeline.test = code_block.test + pipeline.test | ||
| if "cols_has_symbols" in pipeline.test: | ||
| addindex = pipeline.test.index("perm_df = pd.DataFrame") | ||
| pipeline.test = ( | ||
| pipeline.test[:addindex] | ||
| + "feature_train_csv = feature_train.rename(columns=rename_symbol_cols)\n " | ||
| + pipeline.test[addindex:] | ||
| ) | ||
| addindex = pipeline.test.index("prediction = pd.DataFrame") | ||
| pipeline.test = ( | ||
| pipeline.test[:addindex] | ||
| + "TARGET_COLUMNS_csv = [rename_symbol_cols[TARGET_COLUMNS[0]]]\n" | ||
| + pipeline.test[addindex:] | ||
| ) | ||
| else: | ||
| addindex = pipeline.test.index("perm_df = pd.DataFrame") | ||
| pipeline.test = ( | ||
| pipeline.test[:addindex] + "feature_train_csv = feature_train\n " + pipeline.test[addindex:] | ||
| ) | ||
| addindex = pipeline.test.index("prediction = pd.DataFrame") | ||
| pipeline.test = ( | ||
| pipeline.test[:addindex] + "TARGET_COLUMNS_csv = [TARGET_COLUMNS[0]]\n" + pipeline.test[addindex:] | ||
| ) | ||
|
|
||
| pipeline.train = code_block.train + pipeline.train | ||
| pipeline.predict = code_block.predict + pipeline.predict |
There was a problem hiding this comment.
How about the following code?
if "cols_has_symbols" in pipeline.test:
pipeline.test = pipeline.test.replace('perm_df.to_csv', 'perm_df.rename(columns=rename_symbol_cols).to_csv')
def replace_targets(match_obj):
return match_obj[0].replace('TARGET_COLUMNS', "[rename_symbol_cols.get(v, v) for v in TARGET_COLUMNS]")
pat = r"prediction = pd.DataFrame\(y_prob, columns=.?TARGET_COLUMNS.*, index=feature_test.index\)"
pipeline.test = pat.sub(replace_targets, pipeline.test)
pipeline.predict = pat.sub(replace_targets, pipeline.predict)
pipeline.validation = code_block.validation + pipeline.validation
pipeline.test = code_block.test + pipeline.test
pipeline.train = code_block.train + pipeline.train
pipeline.predict = code_block.predict + pipeline.predictThere was a problem hiding this comment.
@AkiraUra
When I modified the code as described in the comments, the output csv column names were not returned from the modified state. (I also modified preprocess.)
The string substitution method of the indicated code is shorter than the previous code, so I will try to fix it referring to this.
There was a problem hiding this comment.
I don't think these changes are necessary.
There was a problem hiding this comment.
I don't think these changes are necessary.
Signed-off-by: tashiro akira <[email protected]>
|
Reflected the content of the review. |
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
auto-merge was automatically disabled
March 22, 2024 07:16
Head branch was pushed to by a user without write access
added 2 commits
March 22, 2024 16:24
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro akira <[email protected]>
Signed-off-by: tashiro-akira <[email protected]>
Signed-off-by: tashiro-akira <[email protected]>
AkiraUra
reviewed
Jun 3, 2024
|
Changed branches and issued new pull requests to capture core and preprocess integration fixes. The correspondence of the comment is also described in the new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AkiraUra @kimusaku
Fix target column names to revert after removing special characters.
This fix is necessary to address the preprocess issue sapientml/preprocess#8.
Please check.