-
Notifications
You must be signed in to change notification settings - Fork 29
Upgrade google formatter to v1.26.0 - Requires Java 17 #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkurz
wants to merge
2
commits into
sbt:main
Choose a base branch
from
mkurz:latest-java-fmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| lazy val scala212 = "2.12.18" | ||
| lazy val scala212 = "2.12.20" | ||
| lazy val scala3 = "3.6.4" | ||
| ThisBuild / scalaVersion := scala212 | ||
| ThisBuild / crossScalaVersions := Seq(scala212, scala3) | ||
|
|
@@ -16,13 +16,13 @@ lazy val plugin = project | |
| ScmInfo(url("https://github.com/sbt/sbt-java-formatter"), "scm:git:[email protected]:sbt/sbt-java-formatter.git")), | ||
| developers := List( | ||
| Developer("ktoso", "Konrad 'ktoso' Malawski", "<[email protected]>", url("https://github.com/ktoso"))), | ||
| libraryDependencies ++= Seq("com.google.googlejavaformat" % "google-java-format" % "1.24.0"), | ||
| libraryDependencies ++= Seq("com.google.googlejavaformat" % "google-java-format" % "1.26.0"), | ||
| startYear := Some(2015), | ||
| description := "Formats Java code in your project.", | ||
| licenses += ("Apache-2.0", url("https://www.apache.org/licenses/LICENSE-2.0.html")), | ||
| (pluginCrossBuild / sbtVersion) := { | ||
| scalaBinaryVersion.value match { | ||
| case "2.12" => "1.9.0" | ||
| case "2.12" => "1.10.11" | ||
| case _ => "2.0.0-M4" | ||
| } | ||
| }, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using
temurinorliberica? 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just it's strange to use different distributions for build and release workflows 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, not sure why zulu was used by Eugene. I remember there was a problem with temurin 8 not being available for the newer ubuntu image or something, or was it for the arm image. Whatever, we can use temurin.