-
Notifications
You must be signed in to change notification settings - Fork 1k
Update Mac installation instructions #3067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove specialized message for Apple Silicon. - Use the `coursier` brew formula.
I will wait for @SethTisue's approval before merging |
@@ -2,5 +2,5 @@ linux-x86-64: curl -fL https://github.com/coursier/coursier/releases/latest/down | |||
linux-arm64: curl -fL https://github.com/VirtusLab/coursier-m1/releases/latest/download/cs-aarch64-pc-linux.gz | gzip -d > cs && chmod +x cs && ./cs setup | |||
macOS-x86-64: curl -fL https://github.com/coursier/coursier/releases/latest/download/cs-x86_64-apple-darwin.gz | gzip -d > cs && chmod +x cs && (xattr -d com.apple.quarantine cs || true) && ./cs setup | |||
macOS-arm64: curl -fL https://github.com/VirtusLab/coursier-m1/releases/latest/download/cs-aarch64-apple-darwin.gz | gzip -d > cs && chmod +x cs && (xattr -d com.apple.quarantine cs || true) && ./cs setup | |||
macOS-brew: brew install coursier/formulas/coursier && cs setup | |||
macOS-brew: brew install coursier && coursier setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from cs
to coursier
? I've never been clear on the difference. I think I usually see cs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because for me, brew install coursier
only installs coursier
. It's then coursier setup
that installs other things such as cs
:
➜ ~ brew install coursier
...
➜ ~ which coursier
/usr/local/bin/coursier
➜ ~ which cs
cs not found
➜ ~ coursier setup
...
Checking if the standard Scala applications are installed
Installed ammonite
Installed cs
Installed coursier
Installed scala
Installed scalac
Installed scala-cli
Installed sbt
Installed sbtn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a difference between the homebrew-core formula and coursier's own tap - core doesn't include cs but the tap does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the tap will only install the x86 cs
, so the core formula is better - as it will resolve the Apple Silicon cs from the cs.json app descriptor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SethTisue the difference is that coursier is a jar-based launcher rather than graalvm native image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I mean at some level this is all deeply confusing and clear as mud, but it sounds like this is mergeable 🤷
coursier
brew formula.