Skip to content

Fail not inlined inline method calls early #22925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fail not inlined inline method calls early #22925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions compiler/src/dotty/tools/dotc/typer/Implicits.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,11 +1294,15 @@ trait Implicits:
val history = ctx.searchHistory.nest(cand, pt)
val typingCtx =
searchContext().setNewTyperState().setFreshGADTBounds.setSearchHistory(history)
val alreadyStoppedInlining = ctx.base.stopInlining
val result = typedImplicit(cand, pt, argument, span)(using typingCtx)
result match
case res: SearchSuccess =>
ctx.searchHistory.defineBynameImplicit(wideProto, res)
case _ =>
if !alreadyStoppedInlining && ctx.base.stopInlining then
// a call overflowed as part of the expansion when typing the implicit
ctx.base.stopInlining = false
// Since the search failed, the local typerstate will be discarded
// without being committed, but type variables local to that state
// might still appear in an error message, so we run `gc()` here to
Expand Down
134 changes: 8 additions & 126 deletions tests/neg/i13044.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,63 +1,18 @@
-- Error: tests/neg/i13044.scala:61:40 ---------------------------------------------------------------------------------
61 | implicit def typeSchema: Schema[A] = Schema.gen // error // error
-- [E172] Type Error: tests/neg/i13044.scala:61:40 ---------------------------------------------------------------------
61 | implicit def typeSchema: Schema[A] = Schema.gen // error
| ^^^^^^^^^^
| given instance gen is declared as `inline`, but was not inlined
| No given instance of type Schema[B] was found.
| I found:
|
| Try increasing `-Xmax-inlines` above 32
| Schema.gen[B]
|
| But given instance gen in trait SchemaDerivation does not match type Schema[B].
|--------------------------------------------------------------------------------------------------------------------
|Inline stack trace
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
| ^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:17
18 | builder :: recurse[ts]
Expand All @@ -71,76 +26,3 @@
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
--------------------------------------------------------------------------------------------------------------------
-- Error: tests/neg/i13044.scala:61:40 ---------------------------------------------------------------------------------
61 | implicit def typeSchema: Schema[A] = Schema.gen // error // error
| ^^^^^^^^^^
| method recurse is declared as `inline`, but was not inlined
|
| Try increasing `-Xmax-inlines` above 32
|--------------------------------------------------------------------------------------------------------------------
|Inline stack trace
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
18 | builder :: recurse[ts]
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
17 | val builder = summonInline[Schema[t]].asInstanceOf[Schema[Any]]
| ^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
18 | builder :: recurse[ts]
| ^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
29 | lazy val fields = recurse[m.MirroredElemTypes]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i13044.scala:18
33 | inline given gen[A]: Schema[A] = derived
| ^^^^^^^
--------------------------------------------------------------------------------------------------------------------
2 changes: 1 addition & 1 deletion tests/neg/i13044.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,5 @@ case class B(c: C)
case class A(a: A, b: B)

object TestApp {
implicit def typeSchema: Schema[A] = Schema.gen // error // error
implicit def typeSchema: Schema[A] = Schema.gen // error
}
24 changes: 24 additions & 0 deletions tests/neg/i22423.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
-- Error: tests/neg/i22423.scala:35:14 ---------------------------------------------------------------------------------
35 | exportReader[Settings] // error
| ^^^^^^^^^^^^^^^^^^^^^^
| cannot reduce summonFrom with
| patterns : case given reader @ _:ConfigReader[List[String]]
|--------------------------------------------------------------------------------------------------------------------
|Inline stack trace
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i22423.scala:12
12 | summonFrom { case reader: ConfigReader[A] => reader }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i22423.scala:12
15 | summonConfigReader[List[String]]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i22423.scala:12
8 | readCaseClass()
| ^^^^^^^^^^^^^^^
|- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|This location contains code that was inlined from i22423.scala:12
30 |inline given exportReader[A]: Exported[ConfigReader[A]] = Exported(HintsAwareConfigReaderDerivation.deriveReader[A])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
--------------------------------------------------------------------------------------------------------------------
35 changes: 35 additions & 0 deletions tests/neg/i22423.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
//> using options -Xmax-inlines:7
import scala.deriving.Mirror
import scala.compiletime._
import scala.compiletime.ops.int._

object HintsAwareConfigReaderDerivation {
inline def deriveReader[A]: ConfigReader[A] =
readCaseClass()
???

private inline def summonConfigReader[A]: ConfigReader[A] =
summonFrom { case reader: ConfigReader[A] => reader }

private inline def readCaseClass(): Unit =
summonConfigReader[List[String]]
val a1: Int = ???
val a2: EmptyTuple = ???
a1 *: a2
???
}

trait ConfigReader[A]
object ConfigReader {
implicit def traversableReader[A, F[A] <: TraversableOnce[A]](implicit configConvert: ConfigReader[A]): ConfigReader[F[A]] = ???
implicit def exportedReader[A](implicit exported: Exported[ConfigReader[A]]): ConfigReader[A] = exported.instance
case class Exported[A](instance: A)
}

import ConfigReader._
inline given exportReader[A]: Exported[ConfigReader[A]] = Exported(HintsAwareConfigReaderDerivation.deriveReader[A])

case class Settings(rules: List[String])

val settings =
exportReader[Settings] // error
Loading