Skip to content

feat(instance): add warning for deprecated instance types #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mia-Cross
Copy link
Contributor

We should display a warning when interacting with an instance which type is flagged with EndOfService. That warning will list compatible offers to guide users in their migration process. We can't fetch the exact date of EndOfService for now, but we could add it to the message in a next PR as soon as we're able to get this information.

The message will be displayed as follows:

│ Warning: Your Instance will soon reach End of Service. You can check the exact date on the Scaleway console. We recommend that you migrate your Instance before that.
│ Here are the best options for "ENT1-S", ordered by relevance: [POP2-8C-32G, POP2-2C-8G, POP2-4C-16G, POP2-16C-64G, POP2-32C-128G, POP2-48C-192G, POP2-64C-256G, GP1-XS, GP1-S, GP1-M, GP1-L, GP1-XL, STARDUST1-S, DEV1-S, DEV1-M, DEV1-L, DEV1-XL, PRO2-XXS, PRO2-XS, PRO2-S, PRO2-M, PRO2-L, PLAY2-PICO, PLAY2-NANO, PLAY2-MICRO, POP2-HM-2C-16G, POP2-HM-4C-32G, POP2-HM-8C-64G, POP2-HM-16C-128G, POP2-HM-32C-256G, POP2-HM-48C-384G, POP2-HM-64C-512G, POP2-HC-2C-4G, POP2-HC-4C-8G, POP2-HC-8C-16G, POP2-HC-16C-32G, POP2-HC-32C-64G, POP2-HC-48C-96G, POP2-HC-64C-128G, POP2-HN-3, POP2-HN-5, POP2-HN-10]
│ 
│   with scaleway_instance_server.eos,
│   on endofservice.tf line 14, in resource "scaleway_instance_server" "eos":
│   14:   type = "ENT1-S"
│ 
│ Instance type "ENT1-S" will soon reach End of Service
╵

@Mia-Cross Mia-Cross added the instance Instance issues, bugs and feature requests label Apr 25, 2025
@Mia-Cross Mia-Cross self-assigned this Apr 25, 2025
@Mia-Cross Mia-Cross marked this pull request as ready for review April 25, 2025 15:55
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners April 25, 2025 15:55
////
// Read Server
////
state, err := serverStateFlatten(server.State)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put those change in a different PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants