scx_rustland: Refactor dispatch_tasks to simplify control flow #1857
+26
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricccTaiwan
force-pushed
the
rustland-refactor
branch
2 times, most recently
from
a1d962e to
4f0664e
Compare
Replaces a match statement with an if-let binding in dispatch_tasks, as the None arm was unused. Also replaces a match on Result with an is_err() check, since only the Err case was handled and the Ok arm was empty. No functional behavior is changed. Signed-off-by: Cheng-Yang Chou <[email protected]>
EricccTaiwan
force-pushed
the
rustland-refactor
branch
from
4f0664e to
2e6f3de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces a match statement with an if-let binding in dispatch_tasks, as the None arm was unused.
Also replaces a match on Result with an is_err() check, since only the Err case was handled and the Ok arm was empty.
No functional behavior is changed.