Skip to content

fix: shape and size of the estia detector #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: shape and size of the estia detector #162

wants to merge 2 commits into from

Conversation

jokasimr
Copy link
Contributor

The shape and size of the detector was off

@jokasimr jokasimr requested a review from paracini May 21, 2025 15:03
jl-wynen
jl-wynen reviewed May 22, 2025
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also reshape when loading from NeXus? That way we check that the sizes are compatible with ECDC's data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jl-wynen jl-wynen jl-wynen left review comments

@paracini paracini Awaiting requested review from paracini

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokasimr @jl-wynen