Track asset provenance when using the paint editor #229
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Something we talked about on the NGP planning
Proposed Changes
Describe what this Pull Request does
Tracks which asset id an asset edited through the paint editor is based on. Tries to only track uploaded (clean) ones. That's what clean means, right?
Requires the change from scratchfoundation/scratch-storage#754
Note on the unused
store
parameter - in NGP we're not using the webHelper for storing (as it doesn't support async functions), so we can just utilize that parameter there to send to the server together with the rest of the asset.Reason for Changes
Explain why these changes should be made
@cwillisf was talking about it and I just opened the code to see how hard it would be, and there you have it - this PR 😄 I haven't tested it and there is no test coverage, so it's left in a Draft state.
Test Coverage
Please show how you have added tests to cover your changes
I didn't 😅