Skip to content

feat: cargo ceno #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 16, 2025
Merged

feat: cargo ceno #902

merged 27 commits into from
Apr 16, 2025

Conversation

lightsing
Copy link
Member

@lightsing lightsing commented Apr 10, 2025

to try, in ceno/ceno_cli/example dir, run:

$ cargo install --path .. --locked
$ cargo ceno run --release --hints 10 --public-io 4 --out-proof proof.bin --out-vk vk.bin
  • cargo ceno build
  • cargo ceno run
  • cargo ceno keygen
  • cargo ceno prove
  • cargo ceno verify

resolve #876

close #813
close #814
close #818
close #819

@lispc lispc self-requested a review April 16, 2025 02:11
@lispc lispc marked this pull request as ready for review April 16, 2025 02:11
@lispc
Copy link
Collaborator

lispc commented Apr 16, 2025

some comments for the e2e.rs

  1. let us still allow load an elf from args. instead of a static predefined program. Though it sounds better to use a fixed elf for a test, but now many people are still use it for day to day tests/benches, let us keep its behavior for a while.
  2. soundness_test, it is part of the bin/e2e.rs, it is part of test. Not part of cargo ceno cli. So in cargo ceno verify, we should not run it. This function should not be located inside a common library-level src file, should be located in bin/example/tests place. Should not move? Or move it out of verify. Make it same level with verify. So in e2e.rs, codes will be like prove(); verify(); soundness_test(); (we move verify into src/e2e.rs, but keep soundness_test in bin/e2e.rs)

@hero78119 hero78119 self-requested a review April 16, 2025 07:05
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lispc lispc added this pull request to the merge queue Apr 16, 2025
Merged via the queue into master with commit b49e3a8 Apr 16, 2025
4 checks passed
@lispc lispc deleted the feat/cargo-ceno branch April 16, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: ceno cli
5 participants