-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/compatibility #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Following new fse header mode has been tested:
|
Passed tests with recent 100 batches as examples |
@@ -15,18 +15,19 @@ strum = "0.25" | |||
strum_macros = "0.25" | |||
anyhow = "1" | |||
serde = { version = "1", default-features = false, features = ["derive"] } | |||
zstd-encoder = { package = "encoder", git = "https://github.com/scroll-tech/da-codec.git", tag = "v0.1.2", optional = true } | |||
zstd-encoder = { package = "encoder", git = "https://github.com/scroll-tech/da-codec.git", branch = "test/prim_zstd", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still Need this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK It is a dev dep actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one question left
Make the decompressor circuit support data generated from zstd lib without any hacking