Skip to content

morty/permissionless batches recovery #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 134 commits into
base: jt/permissionless-batches-recovery
Choose a base branch
from

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Apr 1, 2025

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@yiweichi yiweichi changed the base branch from feat/openvm-euclid-v2 to jt/permissionless-batches-recovery April 3, 2025 07:55
@yiweichi yiweichi requested review from jonastheis and colinlyguo and removed request for jonastheis April 3, 2025 09:25
Run with `make cloud_prover`.

This will prove chunks, the batch and bundle.
Run `make check_proving_status`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not related to this PR, but do we have some docs for the next step? e.g., withdraw the funds in L1. If any, it's nice to have it placed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there should be some more extended docs on how to do this from beginning to end

Copy link
Member Author

@yiweichi yiweichi Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, @jonastheis Do you want me to add those steps? Or you will do it later.

Copy link
Contributor

@jonastheis jonastheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check the failing CI? it seems to pass in the base branch

},
"auth": {
"secret": "prover secret key",
"challenge_expire_duration_sec": 3600,
"secret": "e788b62d39254928a821ac1c76b274a8c835aa1e20ecfb6f50eb10e87847de44",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this value static or does the user need to fill it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For convenience of users, we can make this value static. It won't bring any security issue from my perspective.

Run with `make cloud_prover`.

This will prove chunks, the batch and bundle.
Run `make check_proving_status`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there should be some more extended docs on how to do this from beginning to end

@yiweichi yiweichi requested a review from jonastheis April 25, 2025 23:02
@yiweichi
Copy link
Member Author

The prover/coordinator version is still 0.2.0, will update to 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants