-
Notifications
You must be signed in to change notification settings - Fork 620
morty/permissionless batches recovery #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jt/permissionless-batches-recovery
Are you sure you want to change the base?
morty/permissionless batches recovery #1639
Conversation
This reverts commit fe6451b.
Run with `make cloud_prover`. | ||
|
||
This will prove chunks, the batch and bundle. | ||
Run `make check_proving_status` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not related to this PR, but do we have some docs for the next step? e.g., withdraw the funds in L1. If any, it's nice to have it placed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah there should be some more extended docs on how to do this from beginning to end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, @jonastheis Do you want me to add those steps? Or you will do it later.
…onless-batches-recovery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check the failing CI? it seems to pass in the base branch
}, | ||
"auth": { | ||
"secret": "prover secret key", | ||
"challenge_expire_duration_sec": 3600, | ||
"secret": "e788b62d39254928a821ac1c76b274a8c835aa1e20ecfb6f50eb10e87847de44", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this value static or does the user need to fill it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For convenience of users, we can make this value static. It won't bring any security issue from my perspective.
Run with `make cloud_prover`. | ||
|
||
This will prove chunks, the batch and bundle. | ||
Run `make check_proving_status` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah there should be some more extended docs on how to do this from beginning to end
The prover/coordinator version is still 0.2.0, will update to 0.3.0. |
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?