Skip to content

Braze SDK v5.7 and new regions #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

davidbielik
Copy link
Contributor

Adds v5.6 Braze SDK

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@davidbielik
Copy link
Contributor Author

Hi @joe-ayoub-segment we have a customer blocked on an integration so appreciate your review on this. Thanks!

@joe-ayoub-segment
Copy link
Contributor

hi @davidbielik the PR makes sense to me.
Any chance you can attach proof of some sort of test to demonstrate that it works correctly please?

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jan 17, 2025

If you can provide proof of testing, I can deploy this across Monday and Tuesday ( it takes 2 days to roll out - based on customer tiers).

If you like you could provide me with the source IDs for your customer's Sources which are connected to Braze Web Destinations, and I can include them in the Monday roll out (i.e they will get the updated code on Monday rather than Tuesday).

@davidbielik
Copy link
Contributor Author

Thanks @joe-ayoub-segment . I can't my local environment working. Could you install it on my workspace to QA?

@joe-ayoub-segment
Copy link
Contributor

hi @davidbielik cab you please run 'yarn types' and commit the changed files please?

@joe-ayoub-segment
Copy link
Contributor

hi again @davidbielik - this PR is breaking some tests also. Are you OK fixing this please?

image

@joe-ayoub-segment
Copy link
Contributor

Once you have the test and types fixed I can deploy it to your Workspace.

@davidbielik
Copy link
Contributor Author

image

@joe-ayoub-segment should be all set now, thanks!

@davidbielik
Copy link
Contributor Author

davidbielik commented Feb 7, 2025

Edit - looks like i needed to yarn install the browser-destinations directory to get it to work, but not in the docs.

@joe-ayoub-segment i'm having trouble running tests again - have tried a fresh install, but can't figure this out.

Also, the docs aren't accurate, it talks about yarn bootstrap but that command doesn't exist?

image

@davidbielik davidbielik changed the title Braze SDK v5.6 Braze SDK v5.67 Feb 10, 2025
@davidbielik davidbielik changed the title Braze SDK v5.67 Braze SDK v5.7 and new regions Feb 10, 2025
@davidbielik
Copy link
Contributor Author

davidbielik commented Feb 24, 2025

Hi @joe-ayoub-segment can we merge this when you have a chance?

image image

@brennan
Copy link
Contributor

brennan commented Feb 24, 2025

@davidbielik, thanks for updating/running the tests and following up. Would you mind splitting this PR into two separate PRs, one for browser-destination enhancements, and the other for enhancements to cloud (i.e. those in the destination-actions package)? If we can knock that out, I'll have an engineer review this week. Thank you.

@davidbielik
Copy link
Contributor Author

@brennan thanks

#2761
#2762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants