Skip to content

Post approval updates #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Post approval updates #2942

wants to merge 3 commits into from

Conversation

xitonix
Copy link

@xitonix xitonix commented May 26, 2025

  • Added preset for trackActivity action
  • Removed extra trait properties

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@xitonix xitonix requested a review from a team as a code owner May 26, 2025 05:38
@joe-ayoub-segment joe-ayoub-segment self-assigned this May 26, 2025
@joe-ayoub-segment joe-ayoub-segment mentioned this pull request May 28, 2025
Merged
@joe-ayoub-segment
Copy link
Contributor

I had to fix this PR in another PR #2948
Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels
deploy:push mode:cloud partner-eng-review (cloud) team:external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xitonix @joe-ayoub-segment